-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP Discussion: Extend the fault period of cc sector from 2 weeks to 6 weeks #189
Comments
Relevant post from @zixuanzh #183 (comment)
|
Initial draft was submitted at #190 |
The FIP draft also suggested lowering the wdpost penalty fee, which I think should be decoupled from the scope of this FIP( extend the fault period of cc sector from 2 weeks to 6 weeks). Lowering the wdpost penalty fee may have a large security impact on the network which needs more careful analysis on. |
Totally agree with @jennijuju's comment:
Hastily just lowering the penalty fee without any analysis does not seem like a good idea. |
NOTE: These are hasty "back of the envelop" calculations. Please do your own calculations and don't make important business decisions purely based on this analysis. Let's quickly talk about costs. From my calculations, it will likely be more cost effective to simply buy new hardware and copy the data than to shut down operations and move, assuming a storage provider is able to keep the original data center running while the move is in progress. This is a case where planning ahead is important.
Given the above, it becomes rational to simply buy all new hardware and copy once the expected downtime exceeds Even assuming storage providers are totally unprofitable (all rewards go to upkeep), Importantly, that's assuming buying all new hardware. However, there's a third option: buy, e.g., 10% of the necessary hardware, then move in 10 steps. That will take 10 times longer, but will also be 10 times cheaper. Additionally, these calculations are ignoring the value of the new hardware. If this hardware is eventually used for something, Finally, even if the penalty fee is halved, it's unlikely that shutting down for more than 14 days would be rational given the numbers above. |
Sharing a few thoughts here wrt to the potential meta-governance dynamics of this FIP. Unfortunately due to the rushed nature of the proposal there is not time for a full analysis. That being said, hopefully some of these ideas are useful. From a high level it seems like there is an external event and the response is an internal political process to change network policy (modifying protocol parameters via a FIP). This is not good or bad, but it could set a precedent that in the future, when external events cause exogenous shocks to stakeholders, they can and should use the FIP process to request changes to the protocol. External events are a matter of when, not if. As such, this could affect stakeholder expectations wrt network resilience, incentives, and governance:
These are a few of the dynamics, but there are many more. The point I'm trying to make is that beyond the direct impacts of any decision, how a decision is made will create expectations around how future decisions will be made, which will create expectations around the credibility and stability of the network as a whole. Some of these dynamics were mentioned in #183, but more focused on the details of the FIP itself. To compliment that, thought it might also be useful to also think about these dynamics at a high level. That way it's easier to determine what class of problems are present (in this case responding to the potential shock from an external event), and if the solution at hand is right for that type of problem (an immediate policy decision) and/or if other approaches might be a better fit. TL;DR: even if you don't have a strong opinion on this FIP, the meta-governance dynamics around it could impact future FIPs you do care about, which could inform your opinion on what to do now. |
A rough timeline of this "Issue": Warning, i will only cite a few significant snippets of the mentioned issues - to get the full picture please dive into the threads and make up your own mind! Thanks 19th of March - #84
closed in favor of this discussion: 24th of May - #103
FIPs then created in: 28th of May - #106 23rd of July - #106 closed, discussion delegated back to #103 - no activity in the discussion after that! 29th of September - #183
1st of October - #189
1st of October - #190
Now here we are, needing a decision on this within merely hours:
2 main observations:
About 1.: why rush an implementation? Storage providers had enough time to react to the triggering, external events - since May 24th!
What are we giving incentives out for here if the problem is still existent for storage providers?!?! What would a 4 week extension do for resilient storage? The problem is known for 4 month.... About 2.: why rush an implementation if the main demand, exclusion/lowering of wdPost fees is not even implemented? There are so many open questions regarding the implementation of this FIP that i do not see the need for a termination deadline extesion outweighing these:
Short: There is no urgency, the problem this tries to solve is old. Month old. We should not implement this in the v14 network upgrade - the consqueces are unknown, the impact possibly significant. |
I agree with basically the entirety of @f8-ptrk's post above, and am fairly opposed to this change. The one thing I'd disagree with is
I feel relatively confident that the change has no potentially significant impact. |
@arajasek wouldn't we watering down the rules to a point where we tipple the time a deal could not be proven? i see that ass significant |
@f8-ptrk Yes, 100%, but I think the penalty is high enough that there's no practical impact. It's mostly a weird theoretical point IMO (that the deal may not be stored for almost 33% of the time), but not immediately concerning to me. (Relatedly, I'm not sure how much this will actually help the problem trying to be solved, but that's not my focus here) |
@arajasek I believe
This is actually the issue. This isn't a network related issue but a business one. A FIP is the wrong avenue for requesting help with the actual problem at hand. If SPs have found themselves up the creek without a paddle, then requesting assistance in terms of logistics or contacts or loans or technical support would be the first port of call, not changing how Filecoin works. |
I agree with @jennijuju 's comments. I am in favor of the change but without reducing the penalties. I do not see a risk with this FIP and it serves the community which is at risk of losing a lot of power if this is not adjusted. |
While I agree with the thinking here mostly. However, if we step away from the motivation of the original discussion, some period of extension may help the storage provider community in general. For example, we've got some MinerX fellows who have zfspool incidents in the past few weeks who can benefit from this FIP to buy more time, get more support to recover the sectors before they are permanently gone. |
i agree that we need a solution for sp's in dire situations. but i do not believe that we need it in v14! we should properly discuss this. for my part i think a "default - applies to all" solution is the wrong way to go since most of the sp's will never ever need it. a opt-in solution would be better. or a solution that adds a lifetime limit on not proving a sector, 4-6 weeks overall, not in a row. there are so many ways to make this a screw to fix what is wrong instead of hammering the nail down now in a rush.... |
This is a good suggestion for further disucssion imho. |
That may be the case, but that is not what is being discussed here. Those SPs should be putting forward FIPs that target their problems. They may have the same or similar solution but those are also issues that don't require pushing through changes in an accelerated fashion. |
Reposting from the Core Dev Call Question: Why 6 weeks? from @IPFSUnion
|
if that is the premise then i do not see any reason why someone should ship something across an ocean! we are not talking about a relocation here but a "forced" migration i think btw. the street dwell time (the time it takes to get the container out of the port) on west coast ports is on avg. somewhere between 6 and 8.5 days alone the last weeks. with the amount of ships waiting out there, add another 2 days. shipping stuff that is time critical to the west coast is suicide right now. i doubt it's any better globally... https://www.freightwaves.com/news/record-shattered-61-container-ships-stuck-waiting-off-california |
Closing due to FIP acceptance! |
Motivation
Any country in the world is likely to face force majeure factors such as major natural disasters or social abnormal events, causing storage providers to be unable to provide services normally for a long period of time. To this end, we must plan ahead.
In the current implementation of the protocol, the sector will be forcibly terminated if there are two consecutive weeks of faults. However, two weeks is not enough for a large storage provider to complete the data migration and restart the service. If appropriate measures are not taken, it will not only cause huge economic losses to the storage provider, but also cause large fluctuations in the storage power of the entire Filecoin network.
Therefore, it is necessary to make some adjustments to the sector fault period. Regarding the deal sector, the current data of all transactions is about 32 PiB. It is not a big problem to complete the real data migration within two weeks, but it is far from enough for the EiB level of cc sector to complete the migration within two weeks, so we propose to extend the cc sector fault period from 2 weeks to 6 weeks.
Proposal
Extend fault period of cc sector from 2 weeks to 6 weeks, and calculate the right fee structure.
The text was updated successfully, but these errors were encountered: