Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Diligence Review of DSPA Allocator #21

Closed
filecoin-watchdog opened this issue May 22, 2024 · 6 comments
Closed

Community Diligence Review of DSPA Allocator #21

filecoin-watchdog opened this issue May 22, 2024 · 6 comments
Assignees
Labels
Diligence Audit in Process Governance team is reviewing the DataCap distributions and verifying the deals were within standards

Comments

@filecoin-watchdog
Copy link
Collaborator

Review of DSPA Allocations from @pandacrypto
Allocator Application: filecoin-project/notary-governance#1045

First example:
DataCap was given to:
pandacrypto/DSPA-Allocator#6

Public Open Dataset - key compliance requirement: Retrievability

1st point)
KYC questions asked by allocator but gov team follow up needed to confirm.

2nd point)
Allocation schedule per allocator:
First Round: 512 TiB
Second Round: 1 PiB
Third Round: 2 PiB
Fourth Round: 2 PiB
Overall Cap for Each Client: (2 PiB)

Actual allocation: 512TiB, 1PiB - this does follow their guidelines

3rd point)
SPs provided by client:
-f02809368 Tom Liu Japan
f02812314 Jerry USA
f02812307 Alice Xu Singapore
f02814775 Derek Cui Haarlem, North Holland, NL
f02814770 leo Melbourne, Victoria, AU
f02814767 XHS Koren
f02815438 MaiJie India
f02815448 bluesky USA
f02815451 HZZC Canada
f02815456 Xiangyun US
f02953066 bluesky USA
f02956073 Alice Singapore
f02837684 Xunlei HK
f03028412 ZC Guangdong

https://check.allocator.tech/report/pandacrypto/DSPA-Allocator/issues/6/1716396487509.md

Actual SPs taking deals

Provider | Location | Total Deals Sealed | Percentage | Unique Data | Duplicate Deals | Mean Spark Retrieval Success Rate 7d
f03028412 | Guangzhou, Guangdong, CNHuawei Cloud Service data center | 99.16 TiB | 8.21% | 99.16 TiB | 0.00% | -
f02953066 | Los Angeles, California, USIPTELECOM ASIA | 148.47 TiB | 12.30% | 148.47 TiB | 0.00% | -
f02227496 | Hong Kong, Hong Kong, HKIPTELECOM ASIA | 101.77 TiB | 8.43% | 101.77 TiB | 0.00% | 0.00%
f02837684 | Hong Kong, Hong Kong, HKIPTELECOM Global | 149.91 TiB | 12.42% | 149.91 TiB | 0.00% | -
f02956073 | Singapore, Singapore, SGIPTELECOM Global | 109.86 TiB | 9.10% | 109.86 TiB | 0.00% | -
f03080854 | Piscataway, New Jersey, USThe Constant Company, LLC | 299.66 TiB | 24.82% | 299.66 TiB | 0.00% | -
f03080852 | Toronto, Ontario, CAThe Constant Company, LLC | 298.55 TiB | 24.73% | 298.55 TiB | 0.00% | -

4 of 7 Sps taking deals match - others unknown and locations need additional review to confirm

No retrievals enabled on any SPs per Spark reports. Allocator gave a 2nd 1PiB allocation with no diligence.

@Kevin-FF-USA Kevin-FF-USA self-assigned this May 27, 2024
@Kevin-FF-USA Kevin-FF-USA added the Diligence Audit in Process Governance team is reviewing the DataCap distributions and verifying the deals were within standards label May 27, 2024
@Kevin-FF-USA
Copy link
Collaborator

Hi @pandacrypto

On the next Fil+ Allocator meeting we will be going over each refill application. Wanted to ensure you were tracking the review discussion taking place in #21.

If your schedule allows, recommend coming to the May 28th meeting to answer/discuss the issues raised in the recent distributions. This will allow you to faster address - or, the issue in Allocator Governance for ongoing written discussion.

Warmly,
-Kevin
https://calendar.google.com/calendar/embed?src=c_k1gkfoom17g0j8c6bam6uf43j0%40group.calendar.google.com&ctz=America%2FLos_Angeles

image

@galen-mcandrew
Copy link
Collaborator

Based on an additional compliance review, it appears this allocator is attempting to work with public open dataset clients.

However, the data associated with this pathway is not currently able to be retrieved at scale, and testing for retrieval is currently noncompliant.

As a reminder, the allocator team is responsible for verifying, supporting, and intervening with their clients. If a client is NOT providing accurate deal-making info (such as incomplete or inaccurate SP details) or making deals with noncompliant unretrievable SPs, then the allocator needs to intervene and require client updates before more DataCap should be awarded.

Before we will submit a request for more DataCap to this allocator, please verify that you will instruct, support, and require your clients to work with retrievable storage providers.

@pandacrypto can you verify that you will enforce retrievability requirements, such as through Spark? Please reply here with acknowledgement and any additional details for our review.

@pandacrypto
Copy link

@galen-mcandrew Yes, as a allocator we will continue to follow Spark retrieval requirements until a better tool comes along. We ask clients to contact SPs to study Spark retrieval principles and adjust the configuration to meet Spark retrieval requirements.
image

As you can see, the report shows that there is a gradual improvement in the Spark retrieval success rate.

two weeks ago:
image

now:
image

@pandacrypto
Copy link

pandacrypto commented Jun 12, 2024

As the DSPA allocator operator, we appreciate Kevin-FF @Kevin-FF-USA for assisting us with the preliminary review during the governance meeting. We hope to receive support for 10 PiB DC to facilitate more convenient applications for clients @galen-mcandrew.

The DSPA allocator conducted multiple rounds of KYC in the early stages to ensure data compliance.
image
image
image

Regarding the filecoin-watchdog showing "4 out of 7 SPs reached deals - other transactions unknown," the allocator considers this acceptable because clients can communicate with different SPs before officially distributing data. However, when it comes to actual data storage, factors such as pledge coins, data preparation, network bandwidth, etc., must be considered. We believe that clients are indeed collaborating with the disclosed SPs.

As for Spark retrieval, as mentioned earlier, the success rate of Spark retrieval by SPs has improved, meeting the governance team's requirement of 85%. It is only a matter of time. We have already seen that SPs, clients, and the Spark development team are officially collaborating within the community to improve this.
image

Regarding the new 10 PiB DC distribution, we will also encourage more data types to join. If you have any questions, please feel free to contact me.

@pandacrypto
Copy link

@galen-mcandrew @Kevin-FF-USA

It's exciting that some of the allocators have already been recharged twice, thanks for letting me know what other information I need to provide to expedite the DC refill!

@pandacrypto
Copy link

Looking forward to good news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diligence Audit in Process Governance team is reviewing the DataCap distributions and verifying the deals were within standards
Projects
None yet
Development

No branches or pull requests

4 participants