This repository has been archived by the owner on Feb 23, 2020. It is now read-only.
#738 High level arch for stalbeton parsing #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemijRodionov
approved these changes
Jul 9, 2019
|
|
||
|
|
||
| class Page: | ||
| BASE = 'https://stalbeton.pro' |
There was a problem hiding this comment.
Suggested change
| BASE = 'https://stalbeton.pro' | |
| SITE_URL = 'https://stalbeton.pro' |
| path = '/' | ||
|
|
||
| def url(self) -> str: | ||
| return '/'.join([self.BASE.strip('/'), self.path.strip('/')]) |
There was a problem hiding this comment.
Suggested change
| return '/'.join([self.BASE.strip('/'), self.path.strip('/')]) | |
| return urljoin(self.BASE, self.path) |
|
|
||
|
|
||
| class Command(BaseCommand): | ||
| """Generate yml file for a given vendor (YM or price.ru).""" |
There was a problem hiding this comment.
Suggested change
| """Generate yml file for a given vendor (YM or price.ru).""" |
| second_level = CatalogPage().second_level() | ||
| third_level = chain.from_iterable((s.third_level() for s in second_level)) | ||
| options = chain.from_iterable((t.options() for t in third_level)) # Ignore PyFlakesBear | ||
| # persist it in to our DB |
There was a problem hiding this comment.
Suggested change
| # persist it in to our DB | |
| # save it into our DB |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #738