Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return E305 pycodestyle rule #548

Closed
duker33 opened this issue Aug 25, 2018 · 2 comments
Closed

Return E305 pycodestyle rule #548

duker33 opened this issue Aug 25, 2018 · 2 comments
Assignees
@duker33
Labels
2 performer can implement issue at his closest convenient time 15 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business

Comments

@duker33
Copy link
Contributor

duker33 commented Aug 25, 2018

currently coala's config contains this code string:
pycodestyle_ignore = E305,W503

But it's pep8's rule, as Guide says here: PyCQA/pycodestyle#400
@duker33 duker33 added 15 mins small issues. Usually cosmetic fixes 2 performer can implement issue at his closest convenient time discuss issue needs to finish discussion before start working labels Aug 25, 2018
@duker33 duker33 self-assigned this Aug 25, 2018
@duker33
Copy link
Contributor Author

duker33 commented Aug 25, 2018

@artemiy312 , what do you think about this issue?

@duker33 duker33 mentioned this issue Aug 25, 2018
Merged
@duker33 duker33 added the cleanup everything that do project stronger, flexible, reusable label Aug 25, 2018
@ArtemijRodionov
Copy link
Contributor

@duker33 let's remove these codes from pycodestyle_ignore to stick to pep8

@duker33 duker33 removed the discuss issue needs to finish discussion before start working label Aug 28, 2018
duker33 added a commit that referenced this issue Aug 28, 2018
@duker33
#548 Rm E305 pycodestyle rule
7244c16
duker33 added a commit that referenced this issue Aug 29, 2018
@duker33
#548 Apply E305 linter rule
ec9713d
@duker33 duker33 mentioned this issue Aug 29, 2018
Merged
duker33 added a commit that referenced this issue Sep 6, 2018
@duker33
#548 Apply E305 linter rule
9447654 
#548  Rm E305 pycodestyle rule

#550
- Minor self-review fixes
- Add code example for creating context
- Make context names shorten
- Fork AbstractPageContext
- Cleanup code
- Fork PaginationCategoryContext class
- Fork SortingCategoryContext class
- Fork DBTemplateContext class. Improve pipe mech
- Fork TaggedCategoryContext class
- Implement CatalogContext
- Fork SortingCategoryPage class
- Fork PaginatedCatalogPage class
- Fork DBContextCatalogPage class
- Review#1 fixes. Cache in memory db queries
- Add pdd issue for continue splitting
- Create TaggedCategoryPage class
duker33 added a commit that referenced this issue Sep 7, 2018
@duker33
#550 Review#3 fixes. Rm get_tags caching
bf3146b 
#550  Resolve branch inner conflicts

#550  Apply linter rules

#550  Review#2 fixes. Rm redundant pdd issue, fix imports

#550  Rm redundant pdd issue

#550  Pdd issue about context module improving

#550  Merge fixes after hell

#550  Minor self-review fixes

#550  Add code example for creating context

#550  Make context names shorten

#550  Fork AbstractPageContext

#550  Cleanup code

#550  Fork PaginationCategoryContext class

#550  Fork SortingCategoryContext class

#550  Fork DBTemplateContext class. Improve pipe mech

#550  Fork TaggedCategoryContext class

#550  Implement CatalogContext

#550  Fork SortingCategoryPage class

#550  Fork PaginatedCatalogPage class

#550  Fork DBContextCatalogPage class

#548  Apply E305 linter rule

#550  Review#1 fixes. Cache in memory db queries

#548  Rm E305 pycodestyle rule

#550  Add pdd issue for continue splitting

#550  Create TaggedCategoryPage class
duker33 added a commit that referenced this issue Sep 7, 2018
@duker33
#550 Split TaggedCategoryPage class (#551)
9399dd6 
* #550  Review#3 fixes. Rm get_tags caching

#550  Resolve branch inner conflicts

#550  Apply linter rules

#550  Review#2 fixes. Rm redundant pdd issue, fix imports

#550  Rm redundant pdd issue

#550  Pdd issue about context module improving

#550  Merge fixes after hell

#550  Minor self-review fixes

#550  Add code example for creating context

#550  Make context names shorten

#550  Fork AbstractPageContext

#550  Cleanup code

#550  Fork PaginationCategoryContext class

#550  Fork SortingCategoryContext class

#550  Fork DBTemplateContext class. Improve pipe mech

#550  Fork TaggedCategoryContext class

#550  Implement CatalogContext

#550  Fork SortingCategoryPage class

#550  Fork PaginatedCatalogPage class

#550  Fork DBContextCatalogPage class

#548  Apply E305 linter rule

#550  Review#1 fixes. Cache in memory db queries

#548  Rm E305 pycodestyle rule

#550  Add pdd issue for continue splitting

#550  Create TaggedCategoryPage class

* #550  Merge fixes

* #550  Fix shadowed var

* #550  Apply linter rules after rebase
@duker33 duker33 added the report Put it to completed tasks temporary list for business label Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
2 performer can implement issue at his closest convenient time 15 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @ArtemijRodionov