Skip when no region is set #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnhmcknight thanks for catching this. I'm going to make a small change to the PR to utilize the |
|
@jnhmcknight I updated the PR. I reworded your commit and force pushed the change so that it follows the Conventional Commits guidelines, so please be aware of this if you pull the branch. |
bdb823c to
90ed00c
Compare
Makes things a bit more in line with what Dynaconf expects regarding the use of the ``silent`` parameter. Additionally, we unrolled a large try/except block that really only needed to cover a single statement.
90ed00c to
025319a
Compare
jperras
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in development, Dynaconf does not necessarily need to have credentials sourced, but when loading this extension without credentials, Dynaconf will error out and not proceed past the fact that there are no credentials. I believe this should fail gracefully instead, and skip using this loader.
This outputs the exception, and continues on with Dynaconf loading. Thereby allowing you to know what happened without actually blocking anything.