Fix single-key parameter loading #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole `key` was missing previously, which means that the single-parameter loading capabilities of this loader were... non-existent.
- Also update logging messages to be more useful/clear, and avoid dumping out a stack trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to load a single key via the AWS SSM loader was incorrectly implemented. This PR addresses that issue.
Additionally, unit-ish tests have been added for testing the loader, which supplement the pre-existing Dynaconf integration tests.
Finally, the logger messages were tweaked again to help straddle the line of too much information vs. not enough.