limit spans returned by traces list endpoint

otel-worker-cli/src/data.rs

@@ -178,11 +178,11 @@ impl Store for LibsqlStore {
     async fn traces_list(
         &self,
         _tx: &Transaction,
-        // Future improvement could hold sort fields, limits, etc
+        limit: Option<u32>, // Future improvement could hold sort fields, limits, etc
     ) -> Result<Vec<otel_worker_core::data::models::Trace>> {
         let traces = self
             .connection
-            .query(&self.sql_builder.traces_list(None), ())
+            .query(&self.sql_builder.traces_list(limit), ())
             .await?
             .fetch_all()
             .await?;

otel-worker-core/src/api/handlers/traces.rs

@@ -1,8 +1,8 @@
 use crate::api::errors::{ApiServerError, CommonError};
 use crate::api::models::TraceSummary;
-use crate::data::models::HexEncodedId;
+use crate::data::models::{HexEncodedId, QueryParams};
 use crate::data::{BoxedStore, DbError};
-use axum::extract::{Path, State};
+use axum::extract::{Path, Query, State};
 use axum::Json;
 use http::StatusCode;
 use otel_worker_macros::ApiError;
@@ -13,10 +13,11 @@ use tracing::error;
 #[tracing::instrument(skip_all)]
 pub async fn traces_list_handler(
     State(store): State<BoxedStore>,
+    Query(QueryParams { limit }): Query<QueryParams>,
 ) -> Result<Json<Vec<TraceSummary>>, ApiServerError<TraceListError>> {
     let tx = store.start_readonly_transaction().await?;
 
-    let traces = store.traces_list(&tx).await?;
+    let traces = store.traces_list(&tx, limit).await?;
 
     let mut result = Vec::with_capacity(20);
 

otel-worker-core/src/data.rs

@@ -68,7 +68,7 @@ pub trait Store: Send + Sync {
     async fn traces_list(
         &self,
         tx: &Transaction,
-        // Future improvement could hold sort fields, limits, etc
+        limit: Option<u32>, // Future improvement could hold sort fields, limits, etc
     ) -> Result<Vec<models::Trace>>;
 
     /// Delete all spans with a specific trace_id.

otel-worker-core/src/data/models.rs

@@ -70,6 +70,11 @@ impl From<api::models::Span> for Span {
     }
 }
 
+#[derive(Deserialize)]
+pub struct QueryParams {
+    limit: Option<u32>,
+}
+
 #[derive(Clone, Debug, Serialize, PartialEq)]
 pub struct HexEncodedId(String);
 

otel-worker-core/src/data/sql.rs

@@ -35,8 +35,11 @@ impl SqlBuilder {
     ///
     /// Query parameters:
     /// - $1: trace_id
-    pub fn span_list_by_trace(&self) -> String {
-        String::from("SELECT * FROM spans WHERE trace_id=$1")
+    pub fn span_list_by_trace(&self, limit: Option<u32>) -> String {
+        format!(
+            "SELECT * FROM spans WHERE trace_id=$1 LIMIT {}",
+            limit.unwrap_or(100)
+        )
     }
 
     /// Create a new span.

otel-worker/package.json

@@ -1 +1,3 @@
-{}
+{
+  "packageManager": "pnpm@9.12.3+sha512.cce0f9de9c5a7c95bef944169cc5dfe8741abfb145078c0d508b868056848a87c81e626246cb60967cbd7fd29a6c062ef73ff840d96b3c86c40ac92cf4a813ee"
+}

otel-worker/src/data.rs

@@ -146,11 +146,11 @@ impl Store for D1Store {
     async fn traces_list(
         &self,
         _tx: &Transaction,
-        // Future improvement could hold sort fields, limits, etc
+        limit: Option<u32>, // Future improvement could hold sort fields, limits, etc
     ) -> Result<Vec<models::Trace>> {
         SendFuture::new(async {
             let traces = self
-                .fetch_all(self.sql_builder.traces_list(None), &[])
+                .fetch_all(self.sql_builder.traces_list(limit), &[])
                 .await?;
 
             Ok(traces)