Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dns-search-domains config option. #263

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Add a dns-search-domains config option. #263

merged 2 commits into from
Jan 2, 2025

Conversation

perj
Copy link
Contributor

@perj perj commented Dec 20, 2024

This sets the podSpec.dnsConfig.searches. The main use-case I have in mind is to search services in different namespaces, e.g. if you have a hierarchical namespace setup it can be used to search the parent namespace automatically.

Internal ticket: CDX-24.

This sets the podSpec.dnsConfig.searches. The main use-case I have in
mind is to search services in different namespaces, e.g. if you have a
hierarchical namespace setup it can be used to search the parent
namespace automatically.

Internal ticket: CDX-24.
@perj perj requested a review from a team as a code owner December 20, 2024 11:34
oyvindio
oyvindio previously approved these changes Jan 2, 2025
Copy link
Member

@oyvindio oyvindio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor nitpick, otherwise this looks good 👍

fiaas_deploy_daemon/config.py Outdated Show resolved Hide resolved
@perj perj merged commit c585ab7 into master Jan 2, 2025
6 checks passed
@perj perj deleted the dns-search-domains branch January 2, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants