Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on condition profile based on feedback #91

Merged
merged 13 commits into from
Apr 3, 2023

Conversation

mikajylha
Copy link
Collaborator

@mikajylha mikajylha commented Mar 23, 2023

A step forward on mapping national Diagnosis and Käyntisyy specs to Condition profile.

Generally makes the profile more complete. Defines missing extensions and adds pretty extensive examples. Improves language (contains extension renames).

There was conversation about the overuse and maybe even misuse of category for permanence and primary condition. This PR moves this data to extensions. (There's some back-and-forth movement here, initial design had extensions. Expecting more discussion on this topic.)

Patient refers now to FiBasePatient.

Mika Jylhä added 11 commits March 23, 2023 15:54
"Is not authored by a medical doctor" chapter is obsolete.
Fix wording and improve english translation on extensions.

Document additional code systems that may be used (now and in the
future).

Remove duplicate and partly misleading chapter about
encounter-diagnosis -category.
# Conflicts:
#	input/pagecontent/StructureDefinition-fi-base-condition-intro.md
Describe how to use coding.code.
Moving primary condition and permance information to extensions.

Based on considerations that using category for these pieces of information
was "overusing" or even misusing category.

Permanence to clinicalStatus mapping was also considered, but that's not
easy. Needs more conversation. Using extension as a middle ground
between two "extemes": misusing category and radically redifining
clinicalStatus.
Some text was in finnish.
Renames ExternalCauseOfAdverseEffect --> CauseOfAdverseEffect. The word
"external" is misleading and mixes this with external cause, that is a
different thing.

Adds medication accident -example that illustrates some of the
extensions.
@mikajylha mikajylha marked this pull request as ready for review April 1, 2023 08:50
@mikajylha mikajylha changed the title Diagnosis step3 Improvements on condition profile based on feedback Apr 1, 2023
@mikajylha mikajylha linked an issue Apr 1, 2023 that may be closed by this pull request
@mikajylha mikajylha mentioned this pull request Apr 1, 2023
Copy link
Collaborator

@mrinnetmaki mrinnetmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment regarding heading numbering. Let's discuss on our call. OK to pull this in.


#### Reasons for visit (Diagnosis -based conditions and Finnish *käyntisyy*)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason for me to indent these more is that the IG tooling puts the usage fragment without any header after the intro part. So I attempted to harmonize the intro text of all profiles under the "Scope and Usage" heading.

I acknowledge the heading numbers grow ridiculously big...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing this right away.

Aligns with other profiles.
@mikajylha mikajylha merged commit 4c529e0 into master Apr 3, 2023
@mikajylha mikajylha deleted the diagnosis_step3 branch April 3, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Condition examples should be in examples section
2 participants