Check terminologies #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mikajylha OK like this? Please check.
OK like this @Marvasuo? Please check.
Marvasuo
reviewed
Feb 15, 2023
Comment on lines
23
to
28
| "telecom": [ | ||
| { | ||
| "system": "phone", | ||
| "system": "http://hl7.org/fhir/contact-point-system", | ||
| "code": "phone", | ||
| "value": "0404040404" | ||
| } |
There was a problem hiding this comment.
Telecom is data type of ContactPoint and it doesn't contain "code" value.
https://www.hl7.org/fhir/datatypes.html#ContactPoint
There was a problem hiding this comment.
Agreed and fixed accordingly.
Marvasuo
reviewed
Feb 15, 2023
Comment on lines
15
to
18
| * telecom | ||
| * system = "http://hl7.org/fhir/contact-point-system" | ||
| * code = #phone | ||
| * value = "+358401234657" |
There was a problem hiding this comment.
Agreed and fixed accordingly.
Marvasuo
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the coding should state both the system and the code. @Marvasuo and @mikajylha please check the proposed fixes.