Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Palvelutapahtuma #47

Merged
merged 8 commits into from
Feb 13, 2023
Merged

Palvelutapahtuma #47

merged 8 commits into from
Feb 13, 2023

Conversation

mikajylha
Copy link
Collaborator

No description provided.

Sketch out another palvelutapahtuma interpretation
435d143 
Alternative to the one that uses extension.
@mikajylha mikajylha force-pushed the encounter_service_event_alternative branch from b9ee9c6 to 435d143 Compare February 2, 2023 14:02
@mikajylha mikajylha changed the title Sketch out example palvelutapahtuma interpretation Sketch out another palvelutapahtuma interpretation Feb 2, 2023
@mikajylha mikajylha requested a review from mrinnetmaki February 9, 2023 14:31
@mikajylha mikajylha marked this pull request as ready for review February 9, 2023 14:31
@mikajylha mikajylha changed the title Sketch out another palvelutapahtuma interpretation Palvelutapahtuma Feb 9, 2023
@mikajylha mikajylha requested a review from Marvasuo February 9, 2023 15:00
mrinnetmaki
mrinnetmaki requested changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@mrinnetmaki mrinnetmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get polished references with identifiers?

Also, one "MUST not" should be "MUST NOT".

mrinnetmaki
mrinnetmaki approved these changes Feb 12, 2023
View reviewed changes
Copy link
Collaborator

@mrinnetmaki mrinnetmaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the case of reference.types and changed the first example to use such a format for the reference too. OK?

@mrinnetmaki
Revert "Use structured reference for first example too"
75cf973 
This reverts commit 9005425.

This was the actual id for the resource after all. My bad.
@mikajylha mikajylha merged commit 3b6cd24 into master Feb 13, 2023
@mikajylha mikajylha deleted the encounter_service_event_alternative branch February 13, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrinnetmaki mrinnetmaki mrinnetmaki approved these changes

@Marvasuo Marvasuo Awaiting requested review from Marvasuo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikajylha @mrinnetmaki