-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zero-width/overlay emote support #242
Comments
I don't understand what this emote does where are the technical explanation and visual examples? |
I tried a few to see how it work, will check if possible |
Great work. I found an "RFC" that other twitch app devs seem to follow which documents a way to join emotes without the ZERO WIDTH JOINER since twitch filters it out (twitchdev/issues#307). |
Thanks, I didn't know about the emojis issue. Will take at look at their implementation. Any other emote provider other then 7tv is using zero-width/overlay emotes ? |
I pushed the changes adding the support for the 7tv zero-width/overlay emotes I also included the changes for "RFC" If anything is not working as expected let me know. Thanks! |
I have tested BTTV's extension alone with emotes that should be zero-width like SoSnowy but it does not seem to combine them with anything. I assume they don't support the feature. BTTV allows users to upload any type of emote but does not seem to care if they should be overlayed or not. By looking into 7TV's code I found that they have a hardcoded list of BTTV emotes that they convert to 7TV zero-width emotes. const BTTV_ZeroWidth = ["SoSnowy", "IceCold", "SantaHat", "TopHat", "ReinDeer", "CandyCane", "cvMask", "cvHazmat"]; 7TV converts emotes hosted on BTTV that should be overlayed into 7TV emotes and overlays them. BTTV itself does not support that feature. On FFZ I wasn't able to find any zero-width emotes at all. I appreciate how quickly this feature was implemented and all the effort you’ve put into SmartTwitchTV! |
I did some limit testing and there is no limit to the number of emotes you can overlay with 7TV. I tested up to 12. That being said, the current implementation seems to work fine on other channels. |
You can test by adding the same a few times... I did seems all good. Thanks for the help. You can see on yours channel on this app? Or the twitch site? I assume is a caching thing. |
Wiping the data of the emulator and reinstalling the app fixed it. I have tested multiple overlays as well and everything works just like on 7TV. I think we can consider this issue solved. Great job! |
Thank you! |
Currently, zero-width/overlay emotes display as regular emotes rather than overlaying on other emotes.
Examples of zero-width emotes can be found here: https://7tv.app/emotes?page=1&query=zerowidth&o=1
The text was updated successfully, but these errors were encountered: