feat: Add advice over empty valued <option> in required <select> #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffoodd
requested changes
Jan 11, 2021
sass/themes/_advice.scss
Outdated
| category: Advices | ||
| --- | ||
|
|
||
| ##Description |
There was a problem hiding this comment.
Please add space between ## and titles.
|
Thanks, this is awesome! I made a few comments, mostly wording 👍 |
ffoodd
requested changes
Jan 11, 2021
ffoodd
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added a first version of the check in the project. As it needed several translations, I added the keyword for it in every
locales/*.jsonfile at least in plain English as, if I didn't, it wouldn't compile.Should we give the English translations where we don't know the real translation or shall we use Deepl, Google Translate or some kind of tool alike?
I also added all the
cssandsassfiles to the PR as they are mandatory for translations.Any change needed just tell me 😄
PS: I also added the Spanish language to the languages dropdown so, when the doc is updated and uploaded, we can use it through the bookmarklet.
Closes #404