Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution: do not commit dist/ files #474

Closed
ffoodd opened this issue Aug 8, 2023 · 1 comment · Fixed by #499
Closed

Contribution: do not commit dist/ files #474

ffoodd opened this issue Aug 8, 2023 · 1 comment · Fixed by #499
Labels
enhancement project tooling

Comments

@ffoodd
Copy link
Owner

ffoodd commented Aug 8, 2023

Needs to update contributing guidelines (and maybe enforce it through an action): commiting dist files makes review really hard.

dist files should be updated only when publishing a release.
@ffoodd ffoodd changed the title Contirbution: do not commit dist/ files Contribution: do not commit dist/ files Aug 27, 2024
@ffoodd ffoodd mentioned this issue Aug 27, 2024
Open
@ffoodd
Copy link
Owner Author

ffoodd commented Aug 27, 2024

And maybe check with lefthook or a GitHub action?

ffoodd added a commit that referenced this issue Dec 10, 2024
@ffoodd
chore(repo): remove dist files to close #474
1e41270
ffoodd added a commit that referenced this issue Dec 10, 2024
@ffoodd
chore(Git): cleanup repository by improving .gitignore after #474
91b76f8
@ffoodd ffoodd linked a pull request Dec 10, 2024 that will close this issue
Package content and repo cleanup #499
Merged
@ffoodd ffoodd closed this as completed in 2fd3500 Dec 10, 2024
ffoodd added a commit that referenced this issue Dec 10, 2024
@ffoodd
chore(Git): cleanup repository by improving .gitignore after #474
798b8d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement project tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Package content and repo cleanup ffoodd/a11y.css
1 participant
@ffoodd