New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tabindex error test case #360

Closed

ffoodd opened this issue May 27, 2019 · 0 comments

Assignees

Labels

enhancement selector test

Owner

ffoodd commented May 27, 2019 •

edited

Loading

We'd better test for tabindex starting by - for negative values instead of sticking to a -1 exact match.

This would be nicer: [tabindex]:not([tabindex="0"]):not([tabindex^="-"]) { … }.

And another useful reference to add: https://www.scottohara.me/blog/2019/05/25/tabindex.html

The text was updated successfully, but these errors were encountered:

ffoodd added enhancement test selector labels

ffoodd self-assigned this

ffoodd closed this as completed in

e60289c

ffoodd added a commit that referenced this issue


          feat(tabindex): check for any negative values, for #360

51e46dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment