Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH action extended #37

Merged
merged 1 commit into from
Dec 6, 2021
Merged

GH action extended #37

merged 1 commit into from
Dec 6, 2021

Conversation

chcg
Copy link
Contributor

@chcg chcg commented Nov 27, 2021

  • added arm64 build
  • gh action update check via dependabot
  • added gh mingw build + fix Fix MinGW build #21

@ffes
Copy link
Owner

ffes commented Dec 1, 2021

Thanks for the PR.

I have tried the fix for the Makefile and it worked. Thanks a lot for that!

Although I am not a big fan of adding very different things in one PR, thanks for adding the ARM64 build.

I have added the ARM64 compilers to Visual Studio and that seems to work. But I have no way to check if that works. I don't have a Windows ARM64 device.

And I have a couple of questions:

Why have you added the gh action dependabot?
The project doesn't have any dependencies it can check as far as I am aware of. The only external dependency are SQLite and the NPP headers. But all those files are just copied into the repository. So I don't see any need to add dependabot.

Why is the MinGW-build added to msbuild.yml and not added as a separate mingw-build.yml?

And looking at the YML the BITS=${{ matrix.build_platform }} is not gonna work. I would suggest to change it to something like this (note that I haven't tested this):

- name: build x86
  if: matrix.build_platform == '32'
  run: make ARCH=i686-w64-mingw32

- name: build x64
  if: matrix.build_platform == '64'
  run: make ARCH=x86_64-w64-mingw32

@chcg chcg force-pushed the gh_action branch 2 times, most recently from f1019f5 to bd21c2e Compare December 1, 2021 22:21
@chcg
Copy link
Contributor Author

chcg commented Dec 1, 2021

  • dependabot checks for updated github actions, e.g. if there is a newer version of actions/checkout@v2
  • the mingw build could be splitted into an extra yml file, in my repos it is just named CI_build.yml and therefore I was blind to spot the different file names, corrected that
  • missed to add the variable bits to the makefile, modifying ARCH from the yml is also an option

@ffes
Copy link
Owner

ffes commented Dec 3, 2021

Apart from the small change I requested in the Makefile the PR looks good to me.

- gh action update check
- added gh mingw build
@chcg
Copy link
Contributor Author

chcg commented Dec 4, 2021

adapted gh action and makefile to your suggestion

@ffes ffes merged commit c1ea5eb into ffes:master Dec 6, 2021
@ffes
Copy link
Owner

ffes commented Dec 6, 2021

Thanks again for the PR

@chcg chcg deleted the gh_action branch December 6, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix MinGW build
2 participants