Reimplement cabal check

Cabal-tests/tests/CheckTests.hs

@@ -70,7 +70,7 @@ checkTest fp = cabalGoldenTest fp correct $ do
             -- Note: parser warnings are reported by `cabal check`, but not by
             -- D.PD.Check functionality.
             unlines (map (showPWarning fp) ws) ++
-            unlines (map show (checkPackage gpd Nothing))
+            unlines (map show (checkPackage gpd))
         Left (_, errs) -> unlines $ map (("ERROR: " ++) . showPError fp) $ NE.toList errs
   where
     input = "tests" </> "ParserTests" </> "regressions" </> fp

Cabal-tests/tests/HackageTests.hs

@@ -196,7 +196,7 @@ parseCheckTest fpath bs = do
                              Parsec.parseGenericPackageDescription bs
     case parsec of
         Right gpd -> do
-            let checks = checkPackage gpd Nothing
+            let checks = checkPackage gpd
             let w [] = 0
                 w _  = 1
 

Cabal-tests/tests/ParserTests/regressions/all-upper-bound.check

@@ -1,6 +1,6 @@
 These packages miss upper bounds:
+  - somelib
   - alphalib
   - betalib
   - deltalib
-  - somelib
 Please add them, using `cabal gen-bounds` for suggestions. For more information see:  https://pvp.haskell.org/

Cabal/Cabal.cabal

@@ -84,6 +84,7 @@ library
     Distribution.Compat.Time
     Distribution.Make
     Distribution.PackageDescription.Check
+    Distribution.PackageDescription.Check.Prim
     Distribution.ReadE
     Distribution.Simple
     Distribution.Simple.Bench