Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffac-mt7915: add ramips-mt7622 as feasible install target #13

Merged
merged 1 commit into from
Aug 12, 2024

ffac-mt7915: add ramips-mt7622 as feasible install target

6e13c7c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

ffac-mt7915: add ramips-mt7622 as feasible install target #13

ffac-mt7915: add ramips-mt7622 as feasible install target
6e13c7c
Select commit
Loading
Failed to load commit list.
GitHub Actions / shellcheck succeeded Aug 12, 2024 in 0s

reviewdog [shellcheck] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (35)

tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|17 col 42| Use find instead of ls to better handle non-alphanumeric filenames.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|18 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|24 col 6| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|24 col 11| In POSIX sh, == in place of = is undefined.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|30 col 6| In POSIX sh, FDs outside 0-9 are undefined.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|30 col 10| Double quote to prevent globbing and word splitting.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|32 col 6| Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|38 col 10| Iterating over ls output is fragile. Use globs.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|47 col 44| Double quote to prevent globbing and word splitting.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|48 col 26| Double quote to prevent globbing and word splitting.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|78 col 22| egrep is non-standard and deprecated. Use grep -E instead.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|80 col 4| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|92 col 38| Consider using 'grep -c' instead of 'grep|wc -l'.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|96 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|107 col 10| Double quote to prevent globbing and word splitting.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|108 col 8| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|108 col 13| In POSIX sh, == in place of = is undefined.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|110 col 4| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|124 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|138 col 3| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|147 col 3| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|164 col 13| Double quote to prevent globbing and word splitting.
tecff-broken-wlan-workaround/files/lib/gluon/broken-wlan-workaround/broken-wlan-workaround.sh|168 col 11| Double quote to prevent globbing and word splitting.
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|12 col 7| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|12 col 12| In POSIX sh, == in place of = is undefined.
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|24 col 1| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|26 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|34 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|39 col 1| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|41 col 6| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|41 col 11| In POSIX sh, == in place of = is undefined.
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|55 col 3| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/general-workaround/general-workaround.sh|74 col 2| Remove surrounding $() to avoid executing output (or use eval if intentional).
tecff-general-workaround/files/lib/gluon/state/check.d/can_reach_ntp|3 col 13| Double quote to prevent globbing and word splitting.
tecff-general-workaround/files/lib/gluon/state/check.d/can_reach_ntp|4 col 7| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.