do not vote on own weights #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-hutton
commented
Dec 8, 2021
| @@ -29,7 +29,7 @@ class ProposedWeights(BaseModel): | |||
| weights: Weights | |||
| vote_score: float | |||
| test_score: float | |||
| vote: bool | |||
| vote: Optional[bool] | |||
There was a problem hiding this comment.
None indicates own vote/invalid
added 2 commits
December 8, 2021 12:05
evsmithx
suggested changes
Dec 10, 2021
colearn/standalone_driver.py
Outdated
| learner.mli_accept_weights(prop_weights_list[j].weights) | ||
| # Set all learners to new weights | ||
| for _, learner in enumerate(learners): | ||
| learner.mli_accept_weights(prop_weights_list[0].weights) |
There was a problem hiding this comment.
Minor, but this code would be equivalent and clearer if new_weights replaced prop_weights_list[0].weights. Also if you're not using the loop index then you can get rid of enumerate().
There was a problem hiding this comment.
You marked the conversation as resolved but you haven't fixed it!
colearn/utils/plot.py
Outdated
|
|
||
| # make extra legend entries | ||
| red_patch_handle = mpatches.Patch(color=red_colour / 256, label='Negative vote') | ||
| green_patch_handle = mpatches.Patch(color=green_colour / 256, label='Positive vote') | ||
| grey_patch_handle = mpatches.Patch(color=grey_colour / 256, label='N/A vote') |
There was a problem hiding this comment.
"Did not vote" would be a better label.
n-hutton
commented
Dec 15, 2021
| @@ -181,7 +181,8 @@ def TestWeights(self, request_iterator, context): | |||
| proposed_weights = self.learner.mli_test_weights(weights) | |||
| pw.vote_score = proposed_weights.vote_score | |||
| pw.test_score = proposed_weights.test_score | |||
| pw.vote = proposed_weights.vote | |||
| if proposed_weights.vote is not None: | |||
There was a problem hiding this comment.
grpc allows you to not specify values
evsmithx
previously approved these changes
Dec 15, 2021
colearn/standalone_driver.py
Outdated
| learner.mli_accept_weights(prop_weights_list[j].weights) | ||
| # Set all learners to new weights | ||
| for _, learner in enumerate(learners): | ||
| learner.mli_accept_weights(prop_weights_list[0].weights) |
There was a problem hiding this comment.
You marked the conversation as resolved but you haven't fixed it!
evsmithx
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like: