fix to data downloader #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 23, 2021 00:31
n-hutton
commented
Nov 23, 2021
colearn/utils/data.py
Outdated
| @@ -89,8 +89,19 @@ def _download_data_from_gcloud(cloud_data_dir, local_data_dir): | |||
| file_counter = 0 | |||
| for blob in blobs: | |||
| filename = blob.name | |||
|
|
|||
| if filename[-1] is '/': | |||
There was a problem hiding this comment.
bug addressed here
n-hutton
commented
Nov 23, 2021
| if self.minimise_criterion: | ||
| return new_score <= self.vote_score | ||
| return new_score < self.vote_score |
There was a problem hiding this comment.
unrelated, but looks like it is a bug
There was a problem hiding this comment.
It was a deliberate decision, but it might not be the correct one! I put it that way because otherwise it more quickly gets stuck in the state where no updates are accepted. But I think this way it better.
evsmithx
approved these changes
Nov 29, 2021
| if self.minimise_criterion: | ||
| return new_score <= self.vote_score | ||
| return new_score < self.vote_score |
There was a problem hiding this comment.
It was a deliberate decision, but it might not be the correct one! I put it that way because otherwise it more quickly gets stuck in the state where no updates are accepted. But I think this way it better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vs
In the first example there is a folder (?)
gs://colearn-public/prod_line_failures_strong/0/