Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: working agent broadcast #237

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Conversation

jrriehl
Copy link

@jrriehl jrriehl commented Apr 6, 2023

This is what's needed to make the broadcast work from the agent.

@AbbasAliLokhandwala
Copy link
Collaborator

@jrriehl the code fails if amount entered in decimal format eg 1.3
Also the amount entered is taken in aTestFet instead of FET (probably the reason for above error too)
Agent should convert the amount before creating txn payload for signature

image

@jrriehl
Copy link
Author

jrriehl commented Apr 11, 2023

Yes, good catch. I needed to multiply by 10**18 since we were sending FET amounts to the wallet previously, but now since the txs are serialized, we need to send afet / atestfet/. Anyway, this is fixed now.

@jrriehl jrriehl changed the title feat: working broadcast from agent for transfer feat: working agent broadcast Apr 11, 2023
@AbbasAliLokhandwala AbbasAliLokhandwala merged commit 87df567 into master Apr 12, 2023
@AbbasAliLokhandwala AbbasAliLokhandwala deleted the feat/agent-broadcast branch April 12, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants