Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encryption #200

Merged
merged 110 commits into from
Nov 9, 2024
Merged

Encryption #200

merged 110 commits into from
Nov 9, 2024

Conversation

feschber
Copy link
Owner

@feschber feschber commented Sep 14, 2024 •
edited
Loading

encrypt traffic through dtls using the webrtc dtls implementation
(#104)

Todos

  • Sign certificates using the server (CA = Server?) instead of selfsigned certs. Implement fingerprint based authenticity verification
  • Properly close unresponsive connections
  • Release capture when remote host is not responding to pings
  • Release capture, when a new client connects
  • Only send input events when the connection is acknowledged
  • Release keys, when client does not send pings
  • implement cursor leave logic for one-way control
  • save authenticated keys in config file
  • fix capture release when incoming & outgoing at the same position
  • Fix ping logic for active capture
  • Reinstantiate support for changing ports

feschber added a commit that referenced this pull request Oct 5, 2024
@feschber
reference count capture (#209)
5b1dc4c 
* reference count capture

Multiple captures can now be created at the same position.
Captures at the same position are reference counted.

* update testcase

will be required by #200 / #164
@feschber feschber force-pushed the encryption branch 2 times, most recently from be522dc to 565becd Compare October 8, 2024 12:27
@nbolton
Copy link
Contributor

nbolton commented Oct 11, 2024 •
edited
Loading

Quick thought: Should this be a draft until it's ready for review/merge? Open PRs ping all repo watchers every time there is a new commit (not sure if that's what you wanted). I'm pretty sure drafts don't send notifications.

@feschber
Copy link
Owner Author

Quick thought: Should this be a draft until it's ready for review/merge? Open PRs ping all repo watchers every time there is a new commit (not sure if that's what you wanted). I'm pretty sure drafts don't send notifications.

sorry about that. I was not aware to be honest.

@feschber feschber marked this pull request as draft October 11, 2024 14:14
@nbolton
Copy link
Contributor

nbolton commented Oct 12, 2024 •
edited
Loading

sorry about that. I was not aware to be honest.

Neither was I until someone told me! :D

Edit: I think I was wrong. I realized that I get notifications about other PRs that are just drafts. After some digging it looks like repo watchers are auto-subscribed to draft PRs too, so are notified about all pushes. Sorry for the noise!

@feschber feschber force-pushed the encryption branch 4 times, most recently from 95fee1f to c60bfd3 Compare October 25, 2024 14:50
@feschber feschber force-pushed the encryption branch 3 times, most recently from 01da8c4 to e8d9c7d Compare October 28, 2024 17:09
@feschber feschber force-pushed the encryption branch 4 times, most recently from ef22b8e to ab5dd99 Compare November 5, 2024 13:33
@feschber feschber mentioned this pull request Nov 5, 2024
Closed
@feschber feschber force-pushed the encryption branch 2 times, most recently from bca8889 to 90268bb Compare November 6, 2024 23:42
@feschber feschber marked this pull request as ready for review November 9, 2024 00:35
@feschber feschber merged commit 7677fae into main Nov 9, 2024
10 checks passed
@bdols bdols mentioned this pull request Nov 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feschber @nbolton