Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples imply this functionality exists:
https://github.com/feross/simple-get#form-data
FormData
returns aReadable
, not aBuffer
. The form data example will cause Node to throw with a "first argument must be a buffer or string" error whenreq.end
is called with the stream.I needed simple-get with support for streaming bodies at some point and ended up writing/publishing this:
https://github.com/bendrucker/stream-post
For supporting both streams and strings/buffers through the same interface accepting
{body: readable}
is the smallest working change.