Show error message when saving file in use

Fixes #28
fernandreu · Mar 13, 2019 · ad72d20 · ad72d20
1 parent 93c8440
commit ad72d20
Show file tree

Hide file tree

Showing 2 changed files with 55 additions and 1 deletion.
diff --git a/CustomUIEditor/ViewModels/MainWindowViewModel.cs b/CustomUIEditor/ViewModels/MainWindowViewModel.cs
@@ -464,7 +464,20 @@ private void FinishOpeningFile(string fileName)
         private void Save()
         {
             this.ApplyCurrentText();
-            this.CurrentDocument?.Save(this.ReloadOnSave);
+
+            if (this.CurrentDocument == null)
+            {
+                return;
+            }
+
+            try
+            {
+                this.CurrentDocument.Save(this.ReloadOnSave);
+            }
+            catch (IOException ex)
+            {
+                this.messageBoxService.Show(ex.Message, "Error saving Office document", MessageBoxButton.OK, MessageBoxImage.Error);
+            }
         }
 
         private void SaveAll()

diff --git a/CustomUIEditorTests/ViewModels/MainWindowViewModelTests.cs b/CustomUIEditorTests/ViewModels/MainWindowViewModelTests.cs
@@ -247,6 +247,47 @@ public void InsertSampleTest()
             Assert.AreEqual(contents, part.Contents, "Sample XML file not created with the expected contents");
         }
 
+        /// <summary>
+        /// Checks whether a file being saved while opened in another program is detected correctly and does not cause any crash
+        /// </summary>
+        [Test]
+        public void SaveInUseTest()
+        {
+            File.Copy(this.sourceFile, this.destFile);
+            this.MockOpenFile(this.destFile);
+            this.viewModel.OpenCommand.Execute();
+            this.viewModel.SelectedItem = this.viewModel.DocumentList[0];
+
+            // Open the same file in exclusive mode
+            Assert.DoesNotThrow(() =>
+            {
+                using (File.Open(this.destFile, FileMode.Open, FileAccess.Read, FileShare.None))
+                {
+                    this.viewModel.SaveCommand.Execute();
+                }
+            });
+        }
+
+        /// <summary>
+        /// Checks whether a file being saved with the Save As... option while opened in another program is detected correctly and does not cause any crash
+        /// </summary>
+        [Test]
+        public void SaveAsInUseTest()
+        {
+            this.viewModel.OpenCommand.Execute();
+            this.viewModel.SelectedItem = this.viewModel.DocumentList[0];
+            this.viewModel.SaveAsCommand.Execute();
+
+            // Open the same file in exclusive mode
+            Assert.DoesNotThrow(() =>
+                {
+                    using (File.Open(this.destFile, FileMode.Open, FileAccess.Read, FileShare.None))
+                    {
+                        this.viewModel.SaveAsCommand.Execute();
+                    }
+                });
+        }
+
         private void MockOpenFile(string path)
         {
             this.fileSvc.Setup(x => x.OpenFileDialog(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<Action<string>>(), It.IsAny<string>(), It.IsAny<int>()))