Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depwarns with Julia 0.7 #47

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Fix depwarns with Julia 0.7 #47

merged 1 commit into from
Jul 19, 2018

Conversation

femtotrader
Copy link
Owner

Closes #46

@femtotrader femtotrader requested a review from iblislin July 19, 2018 08:11
iblislin
iblislin approved these changes Jul 19, 2018
View reviewed changes
Copy link
Collaborator

@iblislin iblislin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

report this as a bug of femtocleaner?
I hope my other pkgs can be updated by femtocleaner as well.

@codecov-io
Copy link

codecov-io commented Jul 19, 2018 •
edited
Loading

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files           1        1           
  Lines          96       96           
=======================================
  Hits           93       93           
  Misses          3        3
Impacted Files Coverage Δ
src/TimeFrames.jl 96.87% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b6cfa8...5213808. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.875% when pulling 5213808 on fix_depwarns_julia_0.7 into 4b6cfa8 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Jul 19, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 96.875% when pulling 5213808 on fix_depwarns_julia_0.7 into 4b6cfa8 on master.

@femtotrader femtotrader merged commit 2615e1a into master Jul 19, 2018
@femtotrader femtotrader mentioned this pull request Jul 19, 2018
Open
@iblislin iblislin deleted the fix_depwarns_julia_0.7 branch July 19, 2018 11:09
@femtotrader femtotrader mentioned this pull request Aug 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iblislin iblislin iblislin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@femtotrader @codecov-io @coveralls @iblislin