Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 0.7 #45

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Julia 0.7 #45

merged 2 commits into from
Jul 19, 2018

Conversation

femtotrader
Copy link
Owner

No description provided.

@femtotrader
Copy link
Owner Author

@iblis17 2 tests are still failling.
Any idea?

@femtotrader femtotrader requested a review from iblislin July 18, 2018 16:05
@iblislin
Copy link
Collaborator

I guess the new optimizer in 0.7 is conservative.

@coveralls
Copy link

coveralls commented Jul 19, 2018

Coverage Status

Coverage increased (+0.6%) to 96.875% when pulling 34e7dd2 on update_julia_0.7 into e388ea6 on master.

@codecov-io
Copy link

codecov-io commented Jul 19, 2018

Codecov Report

Merging #45 into master will increase coverage by 0.64%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   96.22%   96.87%   +0.64%     
==========================================
  Files           1        1              
  Lines         106       96      -10     
==========================================
- Hits          102       93       -9     
+ Misses          4        3       -1
Impacted Files Coverage Δ
src/TimeFrames.jl 96.87% <100%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e388ea6...34e7dd2. Read the comment docs.

@iblislin
Copy link
Collaborator

iblislin commented Jul 19, 2018

there are still some depwarns, seems femtocleaner missed the case of range?

   Testing TimeFrames
 Resolving package versions...
Test Summary:            | Pass  Total
low level (period frame) |   16     16
┌ Warning: `range(start, step, length)` is deprecated, use `range(start, step=step, length=length)` instead.
│   caller = range(::DateTime, ::DatePeriodFrame{Day}, ::Int64) at TimeFrames.jl:270
└ @ TimeFrames ~/.julia/dev/TimeFrames/src/TimeFrames.jl:270
┌ Warning: `range(start, step, length)` is deprecated, use `range(start, step=step, length=length)` instead.
│   caller = range(::DatePeriodFrame{Day}, ::DateTime, ::Int64) at TimeFrames.jl:274
└ @ TimeFrames ~/.julia/dev/TimeFrames/src/TimeFrames.jl:274
┌ Warning: InexactError now supports arguments, use `InexactError(funcname::Symbol, ::Type, value)` instead.
│   caller = ip:0x0
└ @ Core :-1
Test Summary: | Pass  Total
high level    |  163    163
   Testing TimeFrames tests passed

@femtotrader
Copy link
Owner Author

Thanks @iblis17
I will tackle depwarns in an other PR

@femtotrader femtotrader merged commit 4b6cfa8 into master Jul 19, 2018
@femtotrader femtotrader mentioned this pull request Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants