Skip to content

Commit

Permalink
Mute FVal E5200 (based on outdated OT spec) for var fonts.
Browse files Browse the repository at this point in the history
  • Loading branch information
felipesanches committed Oct 19, 2018
1 parent df4ce55 commit d2fc08a
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion Lib/fontbakery/specifications/general.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,18 @@ def com_google_fonts_check_037(font):
# contours because they are used to draw each portion
# of variable glyph features.
"Intersecting contours",
"Intersecting components of composite glyph"
"Intersecting components of composite glyph",

# DeltaFormat = 32768 (same as 0x8000) means VARIATION_INDEX,
# according to https://docs.microsoft.com/en-us/typography/opentype/spec/chapter2
# The FontVal problem description for this check (E5200) only mentions
# the other values as possible valid ones. So apparently this means FontVal
# implementation is not up-to-date with more recent versions of the OpenType spec
# and that's why these spurious FAILs are being emitted.
# That's good enough reason to mute it.
# More info at:
# https://github.com/googlefonts/fontbakery/issues/2109
"The device table's DeltaFormat value is invalid"
]

from fontTools.ttLib import TTFont
Expand Down

0 comments on commit d2fc08a

Please sign in to comment.