Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mason_cli): add --set-exit-if-changed for mason bundle #1229

Merged
merged 13 commits into from
Feb 8, 2024
Merged

feat(mason_cli): add --set-exit-if-changed for mason bundle #1229

merged 13 commits into from
Feb 8, 2024

Conversation

alestiago
Copy link
Collaborator

@alestiago alestiago commented Jan 23, 2024 •
edited
Loading

Status

READY FOR REVIEW

Description

Resolves #1213

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago marked this pull request as ready for review January 23, 2024 14:17
@alestiago alestiago requested a review from felangel as a code owner January 23, 2024 14:17
@alestiago alestiago marked this pull request as draft January 23, 2024 14:40
@alestiago alestiago marked this pull request as ready for review January 23, 2024 15:05
@alestiago
Copy link
Collaborator Author

@felangel this is ready for a review 🙌

felangel
felangel previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks so much for the awesome contribution! 💙 ✅

@felangel felangel changed the title feat(mason_cli): include --set-exit-if-changed for mason bundle feat(mason_cli): add --set-exit-if-changed for mason bundle Feb 8, 2024
@felangel felangel merged commit 5cbf7a9 into felangel:master Feb 8, 2024
7 checks passed
@alestiago alestiago deleted the alestiago/bundle-set-exit-if-changed branch February 8, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

Assignees

@alestiago alestiago

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: include --set-exit-if-changed for mason bundle
2 participants
@alestiago @felangel