Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mason_cli): return GeneratedFile when generating bundle instead of path #1228

Closed
wants to merge 1 commit into from
Closed

refactor(mason_cli): return GeneratedFile when generating bundle instead of path #1228

wants to merge 1 commit into from

Conversation

alestiago
Copy link
Collaborator

@alestiago alestiago commented Jan 23, 2024 •
edited
Loading

Status

READY FOR REVIEW

Description

In preparation for #1213 .

Changes:

  • When generating, return GeneratedFile instead of String path.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago changed the title refactor(mason_cli): return GeneratedFile when generating bundle inst… refactor(mason_cli): return GeneratedFile when generating bundle instead of path Jan 23, 2024
@alestiago alestiago closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel Awaiting requested review from felangel felangel will be requested when the pull request is marked ready for review felangel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alestiago