Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate #asJson method #3895

Closed
JurajKubelka opened this issue Jul 14, 2024 · 5 comments
Closed

Deprecate #asJson method #3895

JurajKubelka opened this issue Jul 14, 2024 · 5 comments
Assignees
@JurajKubelka
Labels
cleanup
Milestone
v1.0

Comments

@JurajKubelka
Copy link
Member

#asJson methods that comes from the gt4json repository conflicts with other projects. We therefore deprecate it and use #asGtJson instead.
@JurajKubelka JurajKubelka added this to the v1.0 milestone Jul 14, 2024
@JurajKubelka JurajKubelka self-assigned this Jul 14, 2024
JurajKubelka added a commit to feenkcom/gt4json that referenced this issue Jul 14, 2024
@JurajKubelka
deprecate #asJson [feenkcom/gtoolkit#3895]
a821f71
syrel pushed a commit that referenced this issue Jul 15, 2024
Release version v1.0.979
9b323c0 
Metacello new
    baseline: 'GToolkitForPharo9';
    repository: 'github://feenkcom/gtoolkit:v1.0.979/src';
    load

All commits (including upstream repositories) since last build:
feenkcom/gt4json@a821f7 by Juraj Kubelka
deprecate `#asJson` [#3895]
@Rinzwind Rinzwind mentioned this issue Jul 15, 2024
Closed
@Rinzwind
Copy link

Thanks! The test referred to in Seaside issue #1433 will fail as long as the deprecated #asJson methods remain in GToolkit, so I was wondering at what point they will be removed?

@JurajKubelka
Copy link
Member Author

@Rinzwind: I cannot respond with precisely. I guess at least one year... why does it affects the Seaside code? Is it because Seaside defines #asJson in a superclass?

@Rinzwind
Copy link

Seaside implements #asJson on Object, so GToolkit’s implementation on SequenceableCollection, Dictionary and other classes overrides that.

@JurajKubelka
Copy link
Member Author

@Rinzwind: What if you delete #asJson in your image for now?

@Rinzwind
Copy link

That should work, we’ll probably handle it like that.

@github-project-automation github-project-automation bot moved this to Done in GT Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JurajKubelka JurajKubelka

Labels
cleanup
Projects
GT
Status: Done
Milestone
v1.0
Development

No branches or pull requests
2 participants
@JurajKubelka @Rinzwind