Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Mondrian zooming only work when the primary modifier is held down. #3844

Closed
botwhytho opened this issue Jun 22, 2024 · 5 comments
Closed

Make the Mondrian zooming only work when the primary modifier is held down. #3844

botwhytho opened this issue Jun 22, 2024 · 5 comments
Assignees
@JurajKubelka
Labels
enhancement
Milestone
v1.0

Comments

@botwhytho
Copy link

Currently, in some scenarios, like scrolling through a Lepiter page that has embedded Mondrian elements, the page scrolling is disrupted once the mouse is over a Mondrian element and the element gets zoomed in/out. This is not the desired outcome. There is also a precedent for up/down scrolling doing something different when modifiers are held, if shift is held, it enables left/right scrolling. Holding down primary while scrolling up/down would add a new dimension to this and seems to fit in with other existing UX interactions.
@botwhytho
Copy link
Author

Before (from Discord thread). Since the zoom handler doesn't consume the event, we also get two distinct behaviors at once, zooming and AND scrolling, which is not desired.

ScrollVsZoomConflicts.mp4

@botwhytho
Copy link
Author

First PR Created feenkcom/Bloc#18

@botwhytho
Copy link
Author

Second PR Created feenkcom/gtoolkit-visualizer#10 (depends on first one)

@botwhytho
Copy link
Author

After:

ScrollVsZoomConflictsFixed.mp4

@JurajKubelka JurajKubelka self-assigned this Jun 27, 2024
@JurajKubelka JurajKubelka added this to the v1.0 milestone Jun 27, 2024
JurajKubelka added a commit to feenkcom/gtoolkit-visualizer that referenced this issue Jun 28, 2024
@JurajKubelka
Merge pull request #10 from botwhytho/feature-mondrian-zoom-with-prim…
e415123 
…ary-modifier

Make Mondrian view zoom in/out require primary modifier to be pressed. Consume event. [feenkcom/gtoolkit#3844]
@JurajKubelka
Copy link
Member

@botwhytho: thank you for the contribution.

syrel pushed a commit that referenced this issue Jun 28, 2024
Release version v1.0.901
a22a33f 
Metacello new
    baseline: 'GToolkitForPharo9';
    repository: 'github://feenkcom/gtoolkit:v1.0.901/src';
    load

All commits (including upstream repositories) since last build:
j-brant/SmaCC@d3a028 by John Brant
handle relative path for common parent directory

feenkcom/gtoolkit-inspector@cdcb7a by Tudor Girba
add webpage view for a url #3849

feenkcom/gtoolkit-remote@63c5b2 by Andrei Chi�
Update gemstone demo

feenkcom/gtoolkit-visualizer@e41512 by Juraj Kubelka
Merge pull request #10 from botwhytho/feature-mondrian-zoom-with-primary-modifier

Make Mondrian view zoom in/out require primary modifier to be pressed. Consume event. [#3844]

feenkcom/gtoolkit-visualizer@11e120 by Alberto
Removing usage of testing method on mouse events.

feenkcom/gtoolkit-visualizer@95024f by Alberto
Make Mondrian view zoom in/out require primary modifier to be pressed. Consume event.


feenkcom/gt4git@59d312 by Don Roberts
Use isGitCliRepository method


feenkcom/gt4git@3b9df7 by Don Roberts
Hide all commits tab under libgit

feenkcom/gtoolkit-world@c621a0 by Juraj Kubelka
Lepiter card: make database description updatable [#3847]
@github-project-automation github-project-automation bot moved this to Done in GT Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JurajKubelka JurajKubelka

Labels
enhancement
Projects
GT
Status: Done
Milestone
v1.0
Development

No branches or pull requests
2 participants
@JurajKubelka @botwhytho