Merge c21e7b7

feenkcom · Aug 19, 2024 · ba7ff02 · ba7ff02
2 parents 925242c + c21e7b7
commit ba7ff02
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 23 deletions.
diff --git a/src/Brick-DevTool/BrAnchoredVisualAnalysisElement.class.st b/src/Brick-DevTool/BrAnchoredVisualAnalysisElement.class.st
@@ -124,6 +124,7 @@ BrAnchoredVisualAnalysisElement >> initializeScenePreview [
 					build);
 			clipChildren: false.
 	scalableScenePreview := scenePreview asScalableElement
+			zIndex: -1;
 			margin: (BlInsets all: 30);
 			border: (BlBorder builder
 					dashedSmall;

diff --git a/src/Brick-DevTool/TBlDevScripterActionStep.extension.st b/src/Brick-DevTool/TBlDevScripterActionStep.extension.st
@@ -0,0 +1,13 @@
+Extension { #name : #TBlDevScripterActionStep }
+
+{ #category : #'*Brick-DevTool' }
+TBlDevScripterActionStep >> addDropdownVisualAnalysis [
+	^ self do
+		referenceSender;
+		label: 'Setup dropdown visual analysis';
+		block: [ :anElement :aUserData | 
+			aUserData
+				at: BrAnchoredVisualAnalysis
+				put: (BrAnchoredVisualAnalysis new elementWithDropdown: anElement) ];
+		onParentStepTarget: self
+]
diff --git a/src/Brick/BrDropdownBottomLeftAptitude.class.st b/src/Brick/BrDropdownBottomLeftAptitude.class.st
@@ -24,15 +24,15 @@ BrDropdownBottomLeftAptitude >> initialize [
 						padding:
 							(BlInsets
 								top: 0
-								left: 0 "handle width"
-								bottom: 0 "handle height"
+								left: 0
+								bottom: 0
 								right: 0);
 						removeChild: handle;
 						addChildFirst: handle.
 					content
 						constraintsDo: [ :c | 
-							c horizontal fitContent.
-							c vertical fitContentLimitedOffset: 0 "handle height" ].
+							c horizontal fitContentLimited.
+							c vertical fitContentLimited ].
 					handle
 						constraintsDo: [ :c | 
 							c linear horizontal alignRight.

diff --git a/src/Brick/BrDropdownBottomRightAptitude.class.st b/src/Brick/BrDropdownBottomRightAptitude.class.st
@@ -1,7 +1,7 @@
 Class {
 	#name : #BrDropdownBottomRightAptitude,
 	#superclass : #BrAptitude,
-	#category : 'Brick-Dropdown - Look'
+	#category : #'Brick-Dropdown - Look'
 }
 
 { #category : #initialization }
@@ -25,14 +25,14 @@ BrDropdownBottomRightAptitude >> initialize [
 							(BlInsets
 								top: 0
 								left: 0
-								bottom: handle height
-								right: handle width);
+								bottom: 0
+								right: 0);
 						removeChild: handle;
 						addChildFirst: handle.
 					content
 						constraintsDo: [ :c | 
-							c horizontal fitContent.
-							c vertical fitContentLimitedOffset: handle height ].
+							c horizontal fitContentLimited.
+							c vertical fitContentLimited. ].
 					handle
 						constraintsDo: [ :c | 
 							c linear horizontal alignLeft.

diff --git a/src/Brick/BrDropdownCenterLeftAptitude.class.st b/src/Brick/BrDropdownCenterLeftAptitude.class.st
@@ -1,7 +1,7 @@
 Class {
 	#name : #BrDropdownCenterLeftAptitude,
 	#superclass : #BrAptitude,
-	#category : 'Brick-Dropdown - Look'
+	#category : #'Brick-Dropdown - Look'
 }
 
 { #category : #initialization }
@@ -15,7 +15,7 @@ BrDropdownCenterLeftAptitude >> initialize [
 					handle := widget childNamed: #handle.
 					content := widget childNamed: #content.
 					widget
-						layout: BlFrameLayout new;
+						layout: BlLinearLayout horizontal;
 						constraintsDo: [ :c | 
 							c horizontal fitContentLimited.
 							c vertical fitContentLimited.
@@ -26,8 +26,8 @@ BrDropdownCenterLeftAptitude >> initialize [
 					content
 						margin: (BlInsets left: handle width);
 						constraintsDo: [ :c | 
-							c horizontal fitContent.
-							c vertical fitContentLimitedOffset: handle height ].
+							c horizontal fitContentLimited.
+							c vertical fitContentLimited ].
 					handle
 						constraintsDo: [ :c | 
 							c frame horizontal alignLeft.

diff --git a/src/Brick/BrDropdownTopLeftAptitude.class.st b/src/Brick/BrDropdownTopLeftAptitude.class.st
@@ -1,7 +1,7 @@
 Class {
 	#name : #BrDropdownTopLeftAptitude,
 	#superclass : #BrAptitude,
-	#category : 'Brick-Dropdown - Look'
+	#category : #'Brick-Dropdown - Look'
 }
 
 { #category : #initialization }
@@ -23,16 +23,16 @@ BrDropdownTopLeftAptitude >> initialize [
 							c frame vertical alignBottom ];
 						padding:
 							(BlInsets
-								top: handle height
+								top: 0
 								left: 0
 								bottom: 0
-								right: handle width);
+								right: 0);
 						removeChild: handle;
 						addChild: handle.
 					content
 						constraintsDo: [ :c | 
-							c horizontal fitContent.
-							c vertical fitContentLimitedOffset: handle height ].
+							c horizontal fitContentLimited.
+							c vertical fitContentLimited ].
 					handle
 						constraintsDo: [ :c | 
 							c linear horizontal alignLeft.

diff --git a/src/Brick/BrDropdownTopRightAptitude.class.st b/src/Brick/BrDropdownTopRightAptitude.class.st
@@ -1,7 +1,7 @@
 Class {
 	#name : #BrDropdownTopRightAptitude,
 	#superclass : #BrAptitude,
-	#category : 'Brick-Dropdown - Look'
+	#category : #'Brick-Dropdown - Look'
 }
 
 { #category : #initialization }
@@ -23,16 +23,16 @@ BrDropdownTopRightAptitude >> initialize [
 							c frame vertical alignBottom ];
 						padding:
 							(BlInsets
-								top: handle height
-								left: handle width
+								top: 0
+								left: 0
 								bottom: 0
 								right: 0);
 						removeChild: handle;
 						addChild: handle.
 					content
 						constraintsDo: [ :c | 
-							c horizontal fitContent.
-							c vertical fitContentLimitedOffset: handle height ].
+							c horizontal fitContentLimited.
+							c vertical fitContentLimited ].
 					handle
 						constraintsDo: [ :c | 
 							c linear horizontal alignRight.