Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Proposed restructuring for removal of fh-mbaas-express issue #2 #6

Merged
merged 1 commit into from
May 17, 2017
Merged

Proposed restructuring for removal of fh-mbaas-express issue #2 #6

merged 1 commit into from
May 17, 2017

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented May 17, 2017 •
edited
Loading

Issue #2

Changes:

  • Rename from fh-sync-cloud to just fh-sync (having the 'cloud' in the name makes it sound less standalone)
  • Remove the 'sync' sub-folder in lib, test & integration folders
  • Remove the fh-mbaas-express coupling
  • Remove all non sync code & tests
  • Get all unit & integration tests working via npm test
  • Add a sample server usage of the sync server example/server.js
  • Reset the README.md file to start with standalone sync usage steps
  • Remove unused dependencies from package.json that were carried over
    from fh-mbaas-api

@david-martin
Proposed restructuring for removal of fh-mbaas-express issue #2
482679a 
Changes:

* Remove the 'sync' sub-folder in lib, test & integration folders
* Remove the fh-mbaas-express coupling
* Remove all non sync code & tests
* Get all unit & integration tests working via `npm test`
* Add a sample server usage of the sync server `example/server.js`
* Reset the README.md file to start with standalone sync usage steps
* Remove unused dependencies from package.json that were carried over
from fh-mbaas-api
@david-martin
Copy link
Member Author

david-martin commented May 17, 2017 •
edited
Loading

@wtrocki @aidenkeating @wei-lee Can you review these changes (they are quiet verbose, so i highlighted the changes in the description).
This PR is aimed at completely decoupling fh-sync from any ties with fh-mbaas-* or RHMAP.
Through this decoupling, it should be possible to drop it into fh-mbaas-api as a required module instead.

fyi, i published a placeholder package to https://www.npmjs.com/package/fh-sync until we have a viable first release

wtrocki
wtrocki reviewed May 17, 2017
View reviewed changes
example/server.js

sync.api.init('myDataset', {
syncFrequency: 10 // seconds
}, function() {});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like idea of single simplified server file instead of full app in #1
Going to extend it a little bit after merge.

wtrocki
wtrocki approved these changes May 17, 2017
View reviewed changes
Copy link
Member

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and verified.

@wtrocki wtrocki merged commit 7ca3e60 into master May 17, 2017
@wtrocki wtrocki deleted the remove-fh-mbaas-express branch May 17, 2017 23:19
@david-martin
Copy link
Member Author

@wtrocki thanks for merging. I've enabled the travis build for PRs now.
I've added you and some others to the https://www.npmjs.com/package/fh-sync package on npm too. Feel free to add any other collaborators I've missed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-martin @wtrocki