Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Console errors regarding the FileUploadIcon #1307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Console errors regarding the FileUploadIcon #1307

wants to merge 1 commit into from

Conversation

ondrosh
Copy link
Contributor

@ondrosh ondrosh commented Nov 18, 2024

Changes

  • Fix console errors revolving around the FileUploadIcon

@ondrosh ondrosh requested a review from bo-dun-1 as a code owner November 18, 2024 08:12
bo-dun-1
bo-dun-1 approved these changes Nov 18, 2024
View reviewed changes
src/elements/fields/FileUploadField.tsx
? imgStyles.width
: undefined
}
style={{ 'max-height': '100%' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be camelcase. Also if this is the only place the icon is used, I think you can put the style on the svg directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo-dun-1 bo-dun-1 bo-dun-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ondrosh @bo-dun-1