-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make custom query for authentication #1124
Make custom query for authentication #1124
Conversation
@daffl, I'm not sure what the process is for things like this, so let me know what I need to do. 👍 |
Thank you for the pull request! I think it makes sense to add this but we do need tests and updated documentation otherwise nobody will know about it and we don't know if it works 😄 |
@daffl sounds good, I'll get to that later today! Is the function signature of |
@daffl, I wrote some basic tests to see if the query is being called. Docs changes in feathersjs-ecosystem/docs#1246 |
Great, thank you! Released as |
The current OAuth implementations will update an existing user if it finds one. Great! However, it will only find an existing user if they've authenticated with that specific OAuth provider. But we can give the user the ability determine what an existing user means.
For example:
Now, it would also find users that have the same email, meaning it would link together accounts! Very cool! 👍