fix(transport-commons): Handle invalid service paths on socket lookups (

#3241)
feathersjs · Jul 19, 2023 · c397ab3 · c397ab3
1 parent 043298b
commit c397ab3
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 11 deletions.
diff --git a/packages/transport-commons/src/socket/index.ts b/packages/transport-commons/src/socket/index.ts
@@ -1,11 +1,8 @@
 import { Application, getServiceOptions, Params, RealTimeConnection } from '@feathersjs/feathers'
-import { createDebug } from '@feathersjs/commons'
 import { channels } from '../channels'
 import { routing } from '../routing'
 import { getDispatcher, runMethod } from './utils'
 
-const debug = createDebug('@feathersjs/transport-commons')
-
 export interface SocketOptions {
   done: Promise<any>
   emit: string
@@ -51,10 +48,9 @@ export function socket({ done, emit, socketMap, socketKey, getParams }: SocketOp
           methods.forEach((method) => {
             if (!result[method]) {
               result[method] = (...args: any[]) => {
-                const path = args.shift()
+                const [path, ...rest] = args
 
-                debug(`Got '${method}' call for service '${path}'`)
-                runMethod(app, getParams(connection), path, method, args)
+                runMethod(app, getParams(connection), path, method, rest)
               }
             }
           })

diff --git a/packages/transport-commons/src/socket/utils.ts b/packages/transport-commons/src/socket/utils.ts
@@ -69,10 +69,12 @@ export function getDispatcher(emit: string, socketMap: WeakMap<RealTimeConnectio
 export async function runMethod(
   app: Application,
   connection: RealTimeConnection,
-  path: string,
-  method: string,
+  _path: string,
+  _method: string,
   args: any[]
 ) {
+  const path = typeof _path === 'string' ? _path : null
+  const method = typeof _method === 'string' ? _method : null
   const trace = `method '${method}' on service '${path}'`
   const methodArgs = args.slice(0)
   const callback =
@@ -91,7 +93,7 @@ export async function runMethod(
 
     // No valid service was found throw a NotFound error
     if (lookup === null) {
-      throw new NotFound(`Service '${path}' not found`)
+      throw new NotFound(path === null ? `Invalid service path` : `Service '${path}' not found`)
     }
 
     const { service, params: route = {} } = lookup

diff --git a/packages/transport-commons/test/socket/index.test.ts b/packages/transport-commons/test/socket/index.test.ts
@@ -90,14 +90,26 @@ describe('@feathersjs/transport-commons', () => {
       })
     })
 
-    it('.get with invalid service name and arguments', (done) => {
+    it('method with invalid service name and arguments', (done) => {
       const socket = new EventEmitter()
 
       provider.emit('connection', socket)
 
       socket.emit('get', null, (error: any) => {
         assert.strictEqual(error.name, 'NotFound')
-        assert.strictEqual(error.message, "Service 'null' not found")
+        assert.strictEqual(error.message, 'Invalid service path')
+        done()
+      })
+    })
+
+    it('method with implicit toString errors properly', (done) => {
+      const socket = new EventEmitter()
+
+      provider.emit('connection', socket)
+
+      socket.emit('get', { toString: '' }, (error: any) => {
+        assert.strictEqual(error.name, 'NotFound')
+        assert.strictEqual(error.message, 'Invalid service path')
         done()
       })
     })