Improve adapter service typings

feathersjs · Oct 12, 2022 · 7fad31c · 7fad31c
1 parent f442c89
commit 7fad31c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/packages/knex/src/index.ts b/packages/knex/src/index.ts
@@ -23,9 +23,9 @@ export class KnexService<T = any, D = Partial<T>, P extends KnexAdapterParams<an
     return this._get(id, params)
   }
 
-  async create(data: Partial<D>, params?: P): Promise<T>
-  async create(data: Partial<D>[], params?: P): Promise<T[]>
-  async create(data: Partial<D> | Partial<D>[], params?: P): Promise<T | T[]> {
+  async create(data: D, params?: P): Promise<T>
+  async create(data: D[], params?: P): Promise<T[]>
+  async create(data: D | D[], params?: P): Promise<T | T[]> {
     return this._create(data, params)
   }
 

diff --git a/packages/memory/src/index.ts b/packages/memory/src/index.ts
@@ -209,9 +209,9 @@ export class MemoryService<T = any, D = Partial<T>, P extends AdapterParams = Ad
     return this._get(id, params)
   }
 
-  async create(data: Partial<D>, params?: P): Promise<T>
-  async create(data: Partial<D>[], params?: P): Promise<T[]>
-  async create(data: Partial<D> | Partial<D>[], params?: P): Promise<T | T[]> {
+  async create(data: D, params?: P): Promise<T>
+  async create(data: D[], params?: P): Promise<T[]>
+  async create(data: D | D[], params?: P): Promise<T | T[]> {
     return this._create(data, params)
   }
 

diff --git a/packages/mongodb/src/index.ts b/packages/mongodb/src/index.ts
@@ -24,9 +24,9 @@ export class MongoDBService<
     return this._get(id, params)
   }
 
-  async create(data: Partial<D>, params?: P): Promise<T>
-  async create(data: Partial<D>[], params?: P): Promise<T[]>
-  async create(data: Partial<D> | Partial<D>[], params?: P): Promise<T | T[]> {
+  async create(data: D, params?: P): Promise<T>
+  async create(data: D[], params?: P): Promise<T[]>
+  async create(data: D | D[], params?: P): Promise<T | T[]> {
     return this._create(data, params)
   }