fix: create returns undefined if data is empty array (for multi) #394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the service is defined as
multi = ['create']
and pass in empty array toservice.create
, it will throwTypeError: Cannot read property 'map' of undefined
Hence, this fix adds check to return empty array if the result is undefined so it exits early, and does not throw error
Also, because the test runs on
@feathersjs/adapter-tests
, I can add an updated test case to .create multi if requiredIf this does gets accepted, do consider adding
topic
andlabel
for hacktoberfest so it counts towards the contribution