Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose original MongoDB error following feathers-sequelize methodology #296

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Expose original MongoDB error following feathers-sequelize methodology #296

merged 2 commits into from
Jan 17, 2019

Conversation

cdimitroulas
Copy link
Contributor

@cdimitroulas cdimitroulas commented Jan 17, 2019

Summary

This PR exposes the original MongoDB error along with the formatted one. This is done in the same way as the feathers-sequelize library (see here).
Due to limitations with parsing the original error message with regex to reformat it (does not work for compound indexes) it was decided that it would be best to also return the original error message to the user of the library so that they can understand the problem better in these scenarios.

@daffl daffl merged commit cc97046 into feathersjs-ecosystem:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict error for compound indexes is not correct
2 participants