Build push #56
Merged
Build push #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
January 10, 2019 15:49
|
/assign @woop |
|
/lgtm |
|
actually if we are going to use cloud build for this, I don't think it should skip the tests. /lgtm cancel |
Okay, fair point. My rationale was that the presubmit tests would cover our bases, but better safe than sorry... |
|
/lgtm |
woop
requested changes
Jan 12, 2019
woop
approved these changes
Jan 13, 2019
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yanson
pushed a commit
to Yanson/feast
that referenced
this pull request
Jul 29, 2020
Closes KE-948, KE-957 Run Unit tests using Java 8 for Spark ingestion and historical retriever Deduplicate rows (by entity keys) before running Delta MERGE, as MERGE crashes on duplicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #55.
Adds trigger to google cloud builds watching for semver tag pushes. The images are then pushed to gcr.