Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Operator / Feast should have matching Data Source types #5041

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

tchughesiv
Copy link
Contributor

@tchughesiv tchughesiv commented Feb 10, 2025

What this PR does / why we need it:

The operator needs to remain in sync with the feast data source python class types. This PR ensures that's the case long-term.

@tchughesiv tchughesiv changed the title chore: Operator / Feast - match Data Source types chore: Operator / Feast should have matching Data Source types Feb 10, 2025
@tchughesiv tchughesiv marked this pull request as ready for review February 10, 2025 21:42
@tchughesiv tchughesiv requested a review from a team as a code owner February 10, 2025 21:42
@tchughesiv tchughesiv force-pushed the classTypes branch 3 times, most recently from 4a7c28d to a99e2e6 Compare February 10, 2025 22:00
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
@tmihalac
Copy link
Contributor

lgtm

Copy link
Contributor

@redhatHameed redhatHameed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchughesiv tchughesiv merged commit d937dcb into feast-dev:master Feb 10, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants