Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Operator improvements #4928

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Operator improvements #4928

wants to merge 1 commit into from

Conversation

tchughesiv
Copy link
Contributor

@tchughesiv tchughesiv commented Jan 16, 2025 •
edited
Loading

What this PR does / why we need it:

Several small operator fixes & enhancements, including -

  • Makes DeploymentStrategy configurable via CR
  • Adds support for setting product container images via operator deployment "RELATED_IMAGE_" env vars (through kustomize). This lays the groundwork for ODH/RHOAI integration, custom product images, & disconnected k8s/openshift cluster deployments.
  • OLM bundle generation to demonstrate relatedImages functionality
  • Adds ability to disable the `feast repo initialization' and the 'grpc healthcheck' initContainers
  • Adds a reconcile check for local feast service config in CR
  • Improves ephemeral storage setup and use among the feast services

@tchughesiv tchughesiv force-pushed the minorImprovements branch 3 times, most recently from a44e4f9 to e9d0ff9 Compare January 16, 2025 22:36
@tchughesiv tchughesiv marked this pull request as ready for review January 16, 2025 23:03
@tchughesiv tchughesiv requested a review from a team as a code owner January 16, 2025 23:03
@tchughesiv
operator improvements
b85c58f 
Signed-off-by: Tommy Hughes <tohughes@redhat.com>
lokeshrangineni
lokeshrangineni reviewed Jan 17, 2025
View reviewed changes
infra/feast-operator/internal/controller/services/util.go
return DefaultImage
}

func getGrpcCurlImage() string {
Copy link
Contributor

@lokeshrangineni lokeshrangineni Jan 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why is this image needed? I see it being used to get the k8 service account. Why is this step needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think understood. waiting for the registry server to be up before spinning up the online and offline containers. not sure about the field disableInitContainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lokeshrangineni lokeshrangineni lokeshrangineni left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchughesiv @lokeshrangineni