Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Milvus demo to examples #4910

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

franciscojavierarceo
Copy link
Member

@franciscojavierarceo franciscojavierarceo commented Jan 10, 2025

What this PR does / why we need it:

This pull request introduces several updates and new features to the Feast repository, particularly around the integration of Milvus as an online store. Below is a summary of the key changes:

Documentation Updates

  • Updated Overview of Online Stores: Added Milvus to the matrix of supported functionalities in the overview.md file under docs/reference/online-stores/.

New Example Files

  • RAG Example: Introduced a new example for RAG (Retrieval-Augmented Generation) under examples/rag/.
    • Added __init__.py.
    • Added README.md.
    • Added feature_repo/ directory containing:
      • __init__.py
      • example_repo.py
      • feature_store.yaml
      • test_workflow.py

Code Updates

  • Milvus Online Store Integration:
    • Renamed _get_collection method to _get_or_create_collection in milvus.py.
    • Updated method calls to use _get_or_create_collection instead of _get_collection.
    • Added logic to handle vector fields and search metrics.
    • Improved handling of Proto values and serialization in retrieve_online_documents_v2 method.

Detailed Changes

  1. Documentation:

    • Added Milvus to the list of supported online stores in the feature matrix.
  2. Examples:

    • Added new example files under examples/rag/.
  3. Milvus Integration:

    • Method Renaming: Renamed _get_collection to _get_or_create_collection.
    • Vector Field Handling: Added handling for vector fields and search metrics within the _get_or_create_collection method.
    • Method Updates: Updated the following methods to use _get_or_create_collection:
      • online_write_batch
      • update
      • retrieve_online_documents_v2
    • Proto Value Handling: Improved the handling of Proto values and serialization in retrieve_online_documents_v2.

Which issue(s) this PR fixes:

#4364

Misc

N/A

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
…val of features from vector similarity search

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
@@ -0,0 +1,29 @@
# Feast Quickstart
If you haven't already, check out the quickstart guide on Feast's website (http://docs.feast.dev/quickstart), which
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This README seems a generic quickstart guide with no specific connections with the RAG function or the included example.
I assume that it will be more clear once we run it and see what happens, but I believe than a dev experience driven by a notebook may help, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants