-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Milvus demo to examples #4910
Open
franciscojavierarceo
wants to merge
15
commits into
master
Choose a base branch
from
milvus-demo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+195
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscojavierarceo
force-pushed
the
milvus-demo
branch
2 times, most recently
from
January 10, 2025 21:59
3731e17
to
b7c3426
Compare
franciscojavierarceo
force-pushed
the
milvus-demo
branch
from
January 28, 2025 20:37
55166f0
to
ce41480
Compare
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
…val of features from vector similarity search Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
force-pushed
the
milvus-demo
branch
from
January 29, 2025 01:02
ce41480
to
8360bbb
Compare
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
dmartinol
reviewed
Jan 29, 2025
@@ -0,0 +1,29 @@ | |||
# Feast Quickstart | |||
If you haven't already, check out the quickstart guide on Feast's website (http://docs.feast.dev/quickstart), which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This README seems a generic quickstart guide with no specific connections with the RAG function or the included example.
I assume that it will be more clear once we run it and see what happens, but I believe than a dev experience driven by a notebook may help, WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request introduces several updates and new features to the Feast repository, particularly around the integration of Milvus as an online store. Below is a summary of the key changes:
Documentation Updates
overview.md
file underdocs/reference/online-stores/
.New Example Files
examples/rag/
.__init__.py
.README.md
.feature_repo/
directory containing:__init__.py
example_repo.py
feature_store.yaml
test_workflow.py
Code Updates
_get_collection
method to_get_or_create_collection
inmilvus.py
._get_or_create_collection
instead of_get_collection
.retrieve_online_documents_v2
method.Detailed Changes
Documentation:
Examples:
examples/rag/
.Milvus Integration:
_get_collection
to_get_or_create_collection
._get_or_create_collection
method._get_or_create_collection
:online_write_batch
update
retrieve_online_documents_v2
retrieve_online_documents_v2
.Which issue(s) this PR fixes:
#4364
Misc
N/A