Tests for transformation service integration in java feature server #2236
Conversation
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2236 +/- ##
==========================================
+ Coverage 84.92% 85.21% +0.28%
==========================================
Files 105 106 +1
Lines 8498 8568 +70
==========================================
+ Hits 7217 7301 +84
+ Misses 1281 1267 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -77,17 +72,18 @@ public OnlineTransformationService( | |||
| @Override | |||
| public TransformFeaturesResponse transformFeatures( | |||
| TransformFeaturesRequest transformFeaturesRequest) { | |||
| if (this.stub == null) { | |||
| throw new RuntimeException( | |||
| "Transformation service endpoint must be configured to " + "enable this functionality."); | |||
There was a problem hiding this comment.
@woop this is fixed
|
/lgtm overall. Just the tiny nitpick. |
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pyalex, woop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: pyalex moskalenko.alexey@gmail.com
What this PR does / why we need it:
To keep the transformation functionality in Java FS alive.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: