-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin repo universal tests #1946
Plugin repo universal tests #1946
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
… variable Signed-off-by: Felix Wang <wangfelix98@gmail.com>
/kind feature |
Codecov Report
@@ Coverage Diff @@
## master #1946 +/- ##
===========================================
- Coverage 82.26% 59.41% -22.85%
===========================================
Files 96 96
Lines 7669 7698 +29
===========================================
- Hits 6309 4574 -1735
- Misses 1360 3124 +1764
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adchia, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: This PR allows plugin repos to overwrite
FULL_REPO_CONFIGS
to test against their custom offline/online stores. It also adds theuniversal
pytest marker, to allow plugin repos to easily specify which tests they should run.Which issue(s) this PR fixes:
Fixes #1892
Does this PR introduce a user-facing change?: