Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin repo universal tests #1946

Merged

Conversation

felixwang9817
Copy link
Collaborator

What this PR does / why we need it: This PR allows plugin repos to overwrite FULL_REPO_CONFIGS to test against their custom offline/online stores. It also adds the universal pytest marker, to allow plugin repos to easily specify which tests they should run.

Which issue(s) this PR fixes:

Fixes #1892

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
… variable

Signed-off-by: Felix Wang <wangfelix98@gmail.com>
@felixwang9817
Copy link
Collaborator Author

/kind feature

@feast-ci-bot feast-ci-bot added kind/feature New feature or request and removed needs-kind labels Oct 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #1946 (cae91d4) into master (cd0e0e0) will decrease coverage by 22.84%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1946       +/-   ##
===========================================
- Coverage   82.26%   59.41%   -22.85%     
===========================================
  Files          96       96               
  Lines        7669     7698       +29     
===========================================
- Hits         6309     4574     -1735     
- Misses       1360     3124     +1764     
Flag Coverage Δ
integrationtests ?
unittests 59.41% <70.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/integration/feature_repos/repo_configuration.py 54.54% <53.84%> (-45.46%) ⬇️
sdk/python/tests/conftest.py 69.44% <62.50%> (-24.31%) ⬇️
sdk/python/feast/constants.py 100.00% <100.00%> (ø)
...python/tests/integration/e2e/test_universal_e2e.py 30.61% <100.00%> (-56.89%) ⬇️
...fline_store/test_universal_historical_retrieval.py 17.73% <100.00%> (-81.56%) ⬇️
.../integration/online_store/test_universal_online.py 14.39% <100.00%> (-84.85%) ⬇️
...istration/test_universal_odfv_feature_inference.py 40.00% <100.00%> (-60.00%) ⬇️
...s/integration/registration/test_universal_types.py 36.73% <100.00%> (-63.27%) ⬇️
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0e0e0...cae91d4. Read the comment docs.

Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow plugin repos to test against universal test suite
4 participants