-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure docstring tests always teardown #1817
Conversation
Signed-off-by: Felix Wang <wangfelix98@gmail.com>
/kind bug |
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
- Coverage 84.85% 84.83% -0.03%
==========================================
Files 92 92
Lines 6828 6837 +9
==========================================
+ Hits 5794 5800 +6
- Misses 1034 1037 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, felixwang9817 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Felix Wang wangfelix98@gmail.com
What this PR does / why we need it: Occasionally docstring tests are not cleaned up properly. This test ensures they always teardown correctly.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: