Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessay path join in setup.py #1529

Merged
merged 1 commit into from
May 1, 2021
Merged

remove unnecessay path join in setup.py #1529

merged 1 commit into from
May 1, 2021

Conversation

shihabuddinbuet
Copy link
Contributor

@shihabuddinbuet shihabuddinbuet commented Apr 30, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@feast-ci-bot
Copy link
Collaborator

Hi @shihabuddinbuet. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jklegar
Copy link
Collaborator

jklegar commented May 1, 2021

/kind housekeeping

@jklegar
Copy link
Collaborator

jklegar commented May 1, 2021

/ok-to-test

Copy link
Collaborator

@jklegar jklegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jklegar, shihabuddinbuet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jklegar
Copy link
Collaborator

jklegar commented May 1, 2021

/lgtm

@feast-ci-bot feast-ci-bot merged commit f6f00fc into feast-dev:master May 1, 2021
jklegar pushed a commit to jklegar/feast that referenced this pull request May 12, 2021
Co-authored-by: shihabuddin <shihabuddin@pathao.com>
jklegar pushed a commit that referenced this pull request May 12, 2021
Co-authored-by: shihabuddin <shihabuddin@pathao.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants