Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configurable options and add sphinx docs #1174

Merged
merged 12 commits into from
Nov 19, 2020
Merged

Refactor configurable options and add sphinx docs #1174

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
22838c8
Refactor constants and add sphinx docs
terryyylim Nov 18, 2020
3834444
Set default jobservice to none
terryyylim Nov 18, 2020
fc5c87b
Fix auth tests
terryyylim Nov 18, 2020
6022ddc
Some fixes
terryyylim Nov 18, 2020
fe6f433
Address comments
terryyylim Nov 18, 2020
d310f17
Address comments
terryyylim Nov 18, 2020
469f38c
Test none default
terryyylim Nov 18, 2020
36bc636
Set default as none
terryyylim Nov 18, 2020
889c0cd
Update docs
terryyylim Nov 18, 2020
0cca6f8
Cleanup spark launcher constant
terryyylim Nov 19, 2020
cf06308
Update constants and clarify docstring
terryyylim Nov 19, 2020
4d7be0e
Polish docstrings
terryyylim Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion sdk/python/docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,11 @@ Feature

.. automodule:: feast.feature
:inherited-members:
:members:
:members:

Constants
==================

.. automodule:: feast.constants
:members:
:exclude-members: AuthProvider, ConfigMeta
6 changes: 3 additions & 3 deletions sdk/python/feast/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

from feast.client import Client
from feast.config import Config
from feast.constants import CONFIG_SPARK_LAUNCHER
from feast.constants import ConfigOptions as opt
from feast.entity import Entity
from feast.feature_table import FeatureTable
from feast.job_service import start_job_service
Expand Down Expand Up @@ -422,7 +422,7 @@ def stop_stream_to_online(feature_table: str):
Stop stream to online sync job
"""

spark_launcher = Config().get(CONFIG_SPARK_LAUNCHER)
spark_launcher = Config().get(opt.SPARK_LAUNCHER)

if spark_launcher == "emr":
import feast.pyspark.aws.jobs
Expand All @@ -441,7 +441,7 @@ def list_jobs():
"""
from tabulate import tabulate

spark_launcher = Config().get(CONFIG_SPARK_LAUNCHER)
spark_launcher = Config().get(opt.SPARK_LAUNCHER)

if spark_launcher == "emr":
import feast.pyspark.aws.jobs
Expand Down
Loading