chore: Remove all usage of RequestFeatureView (#4039)

remove all usage of RequestFeatureViews Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
feast-dev · Mar 26, 2024 · cf58ebe · cf58ebe
1 parent e703b40
commit cf58ebe
Show file tree

Hide file tree

Showing 23 changed files with 19 additions and 696 deletions.
diff --git a/protos/feast/core/Registry.proto b/protos/feast/core/Registry.proto
@@ -27,7 +27,6 @@ import "feast/core/FeatureTable.proto";
 import "feast/core/FeatureView.proto";
 import "feast/core/InfraObject.proto";
 import "feast/core/OnDemandFeatureView.proto";
-import "feast/core/RequestFeatureView.proto";
 import "feast/core/StreamFeatureView.proto";
 import "feast/core/DataSource.proto";
 import "feast/core/SavedDataset.proto";
@@ -41,7 +40,6 @@ message Registry {
     repeated FeatureView feature_views = 6;
     repeated DataSource data_sources = 12;
     repeated OnDemandFeatureView on_demand_feature_views = 8;
-    repeated RequestFeatureView request_feature_views = 9;
     repeated StreamFeatureView stream_feature_views = 14;
     repeated FeatureService feature_services = 7;
     repeated SavedDataset saved_datasets = 11;

diff --git a/protos/feast/core/RequestFeatureView.proto b/protos/feast/core/RequestFeatureView.proto
diff --git a/protos/feast/registry/RegistryServer.proto b/protos/feast/registry/RegistryServer.proto
@@ -7,7 +7,6 @@ import "feast/core/Registry.proto";
 import "feast/core/Entity.proto";
 import "feast/core/DataSource.proto";
 import "feast/core/FeatureView.proto";
-import "feast/core/RequestFeatureView.proto";
 import "feast/core/StreamFeatureView.proto";
 import "feast/core/OnDemandFeatureView.proto";
 import "feast/core/FeatureService.proto";
@@ -28,10 +27,6 @@ service RegistryServer{
   rpc GetFeatureView (GetFeatureViewRequest) returns (feast.core.FeatureView) {}
   rpc ListFeatureViews (ListFeatureViewsRequest) returns (ListFeatureViewsResponse) {}
 
-  // RequestFeatureView RPCs
-  rpc GetRequestFeatureView (GetRequestFeatureViewRequest) returns (feast.core.RequestFeatureView) {}
-  rpc ListRequestFeatureViews (ListRequestFeatureViewsRequest) returns (ListRequestFeatureViewsResponse) {}
-
   // StreamFeatureView RPCs
   rpc GetStreamFeatureView (GetStreamFeatureViewRequest) returns (feast.core.StreamFeatureView) {}
   rpc ListStreamFeatureViews (ListStreamFeatureViewsRequest) returns (ListStreamFeatureViewsResponse) {}
@@ -126,23 +121,6 @@ message ListFeatureViewsResponse {
     repeated feast.core.FeatureView feature_views = 1;
 }
 
-// RequestFeatureView
-
-message GetRequestFeatureViewRequest {
-    string name = 1;
-    string project = 2;
-    bool allow_cache = 3;
-}
-
-message ListRequestFeatureViewsRequest {
-    string project = 1;
-    bool allow_cache = 2;
-}
-
-message ListRequestFeatureViewsResponse {
-    repeated feast.core.RequestFeatureView request_feature_views = 1;
-}
-
 // StreamFeatureView
 
 message GetStreamFeatureViewRequest {

diff --git a/sdk/python/docs/source/feast.protos.feast.core.rst b/sdk/python/docs/source/feast.protos.feast.core.rst
@@ -228,22 +228,6 @@ feast.protos.feast.core.Registry\_pb2\_grpc module
    :undoc-members:
    :show-inheritance:
 
-feast.protos.feast.core.RequestFeatureView\_pb2 module
-------------------------------------------------------
-
-.. automodule:: feast.protos.feast.core.RequestFeatureView_pb2
-   :members:
-   :undoc-members:
-   :show-inheritance:
-
-feast.protos.feast.core.RequestFeatureView\_pb2\_grpc module
-------------------------------------------------------------
-
-.. automodule:: feast.protos.feast.core.RequestFeatureView_pb2_grpc
-   :members:
-   :undoc-members:
-   :show-inheritance:
-
 feast.protos.feast.core.SavedDataset\_pb2 module
 ------------------------------------------------
 

diff --git a/sdk/python/docs/source/feast.rst b/sdk/python/docs/source/feast.rst
@@ -273,14 +273,6 @@ feast.repo\_upgrade module
    :undoc-members:
    :show-inheritance:
 
-feast.request\_feature\_view module
------------------------------------
-
-.. automodule:: feast.request_feature_view
-   :members:
-   :undoc-members:
-   :show-inheritance:
-
 feast.saved\_dataset module
 ---------------------------
 

diff --git a/sdk/python/feast/__init__.py b/sdk/python/feast/__init__.py
@@ -22,7 +22,6 @@
 from .field import Field
 from .on_demand_feature_view import OnDemandFeatureView
 from .repo_config import RepoConfig
-from .request_feature_view import RequestFeatureView
 from .stream_feature_view import StreamFeatureView
 from .value_type import ValueType
 
@@ -49,7 +48,6 @@
     "BigQuerySource",
     "FileSource",
     "RedshiftSource",
-    "RequestFeatureView",
     "SnowflakeSource",
     "PushSource",
     "RequestSource",

diff --git a/sdk/python/feast/cli.py b/sdk/python/feast/cli.py
@@ -381,7 +381,6 @@ def feature_view_list(ctx: click.Context):
     table = []
     for feature_view in [
         *store.list_feature_views(),
-        *store.list_request_feature_views(),
         *store.list_on_demand_feature_views(),
     ]:
         entities = set()

diff --git a/sdk/python/feast/diff/registry_diff.py b/sdk/python/feast/diff/registry_diff.py
@@ -20,9 +20,6 @@
     OnDemandFeatureView as OnDemandFeatureViewProto,
 )
 from feast.protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec
-from feast.protos.feast.core.RequestFeatureView_pb2 import (
-    RequestFeatureView as RequestFeatureViewProto,
-)
 from feast.protos.feast.core.StreamFeatureView_pb2 import (
     StreamFeatureView as StreamFeatureViewProto,
 )
@@ -110,7 +107,6 @@ def tag_objects_for_keep_delete_update_add(
     FeatureViewProto,
     FeatureServiceProto,
     OnDemandFeatureViewProto,
-    RequestFeatureViewProto,
     StreamFeatureViewProto,
     ValidationReferenceProto,
 )
@@ -339,7 +335,6 @@ def apply_diff_to_registry(
             elif feast_object_diff.feast_object_type in [
                 FeastObjectType.FEATURE_VIEW,
                 FeastObjectType.ON_DEMAND_FEATURE_VIEW,
-                FeastObjectType.REQUEST_FEATURE_VIEW,
                 FeastObjectType.STREAM_FEATURE_VIEW,
             ]:
                 feature_view_obj = cast(
@@ -383,7 +378,6 @@ def apply_diff_to_registry(
             elif feast_object_diff.feast_object_type in [
                 FeastObjectType.FEATURE_VIEW,
                 FeastObjectType.ON_DEMAND_FEATURE_VIEW,
-                FeastObjectType.REQUEST_FEATURE_VIEW,
                 FeastObjectType.STREAM_FEATURE_VIEW,
             ]:
                 registry.apply_feature_view(

diff --git a/sdk/python/feast/feast_object.py b/sdk/python/feast/feast_object.py
@@ -11,20 +11,17 @@
 from .protos.feast.core.FeatureService_pb2 import FeatureServiceSpec
 from .protos.feast.core.FeatureView_pb2 import FeatureViewSpec
 from .protos.feast.core.OnDemandFeatureView_pb2 import OnDemandFeatureViewSpec
-from .protos.feast.core.RequestFeatureView_pb2 import RequestFeatureViewSpec
 from .protos.feast.core.StreamFeatureView_pb2 import StreamFeatureViewSpec
 from .protos.feast.core.ValidationProfile_pb2 import (
     ValidationReference as ValidationReferenceProto,
 )
-from .request_feature_view import RequestFeatureView
 from .saved_dataset import ValidationReference
 from .stream_feature_view import StreamFeatureView
 
 # Convenience type representing all Feast objects
 FeastObject = Union[
     FeatureView,
     OnDemandFeatureView,
-    RequestFeatureView,
     BatchFeatureView,
     StreamFeatureView,
     Entity,
@@ -36,7 +33,6 @@
 FeastObjectSpecProto = Union[
     FeatureViewSpec,
     OnDemandFeatureViewSpec,
-    RequestFeatureViewSpec,
     StreamFeatureViewSpec,
     EntitySpecV2,
     FeatureServiceSpec,