Skip to content

Commit

Permalink
Output Subject Claim as Identity in Logging interceptor (#946)
Browse files Browse the repository at this point in the history
* Move GrpcMessageInterceptor into auth package to prevent circular dependency.

* Update GrpcMessageInterceptor to output subject claim as identity instead of just id

For the 'google' authentication provider this means that the email would
be output as identity instead of just a user id

* Remove print statement

* Fix null in GrpcMessageInterceptor when subjectClaim not set.

* Add comment for SUBJECT_CLAIM constant in SecurityProperties

* Move subjectClaim option to authorization's options.

* This is done as subjectClaim would be used even when only
  authentication is enabled.
* For HttpAuthorizationProvider, which requires both authentication and
  authorization options, the options maps are merged together.

* Fix bad import on JobControllerServiceImpl importing GrpcMessageInterceptor

* Fix issue where jobcontroller's spring cannot find GrpcMessageInterceptor

* Allow GrpcMessageInterceptor to function without securityProperties specified (ie in Job Controller).

* Fix wrong method used to make securityProperties param in GrpcMessageInterceptor optinal

* Fix missing WebSecurityConfigurerAdapter on jobcontroller start by adding dummy WebSecurityConfig

As GrpcMessageInterceptor is moved feast-auth package to prevent a
circular dependency, jobcontroller has to import feast-auth to get
GrpcMessageInterceptor. feast-auth also imports spring security,
which automatically requires WebSecurityConfigurerAdapter to be present
in the spring application context.

Commit provides a dummy WebSecurityConfigurerAdapter required to
statisfy spring.

* Merge feast-auth module into feast-common under feast.auth.common.

* Move version specification to parent pom.xml instead of feast-common pom.xml

* Revert GrpcMessageInterceptor back to feast.common.logging.interceptors package

* Add missing openapi generator ignore file.

* Fix compile issue by disabling doclint.

* Fix junit class not being able to be use in integration test

* Remove copy of auth/pom.xml since merge of auth into feast-common.

* Renable doclint but disable javadocs for openapi auth client package.

* Fixed issue where AuditLogger was not picked up as a spring component in JobController

* Disable Spring Security for JobController by excluding autoconfigure bean instead of WebSecurityConfig
  • Loading branch information
mrzzy authored Aug 31, 2020
1 parent 4c76e7c commit b61c3a1
Show file tree
Hide file tree
Showing 39 changed files with 407 additions and 345 deletions.
217 changes: 0 additions & 217 deletions auth/pom.xml

This file was deleted.

File renamed without changes.
Loading

0 comments on commit b61c3a1

Please sign in to comment.